classification
Title: timeout sentinel in ftplib and poplib documentation
Type: behavior Stage: patch review
Components: Documentation Versions: Python 3.7, Python 3.6, Python 3.5
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: docs@python Nosy List: berker.peksag, docs@python, mawidjaj, orsenthil, εσχατοκυριος
Priority: normal Keywords: easy, patch

Created on 2011-08-07 08:33 by orsenthil, last changed 2018-01-25 05:01 by mawidjaj.

Files
File name Uploaded Description Edit
patch.patch εσχατοκυριος, 2014-06-07 21:12 review
Pull Requests
URL Status Linked Edit
PR 5309 open mawidjaj, 2018-01-25 05:01
Messages (5)
msg141740 - (view) Author: Senthil Kumaran (orsenthil) * (Python committer) Date: 2011-08-07 08:33
- ftplib and poplib, has them as timeout=None, while they default                                                                               
 to socket._GLOBAL_DEFAULT_TIMEOUT object.                                                                                                           
                                                                                                                                                      
This is wrong; someone may pass None thinking it will trigger the                                                                                     
default behaviour, and have nasty surprises.
msg219975 - (view) Author: Greg (εσχατοκυριος) * Date: 2014-06-07 21:12
In the definition of FTP.connect(), I've changed the code to actually use None as a lack-of-explicit-timeout sentinel instead of -999. For FTP and FTP_TLS, I've changed the documentation to reflect what the code is doing.
msg278116 - (view) Author: Berker Peksag (berker.peksag) * (Python committer) Date: 2016-10-05 10:06
Documentation changes look good to me. However, I'd prefer using socket._GLOBAL_DEFAULT_TIMEOUT in the timeout parameter of FTP.connect().
msg309186 - (view) Author: Marcel Widjaja (mawidjaj) * Date: 2017-12-29 18:55
Greg, I wonder if you are planning to submit a PR for your patch? If not, I'm plan to take your patch, make some minor adjustment and submit a PR.
msg309482 - (view) Author: Greg (εσχατοκυριος) * Date: 2018-01-04 21:03
Completely forgot about this, please take my patch and submit a pr

On Fri, Dec 29, 2017 at 10:55 AM, Marcel Widjaja <report@bugs.python.org>
wrote:

>
> Marcel Widjaja <mwidj@yahoo.com> added the comment:
>
> Greg, I wonder if you are planning to submit a PR for your patch? If not,
> I'm plan to take your patch, make some minor adjustment and submit a PR.
>
> ----------
> nosy: +mawidjaj
>
> _______________________________________
> Python tracker <report@bugs.python.org>
> <https://bugs.python.org/issue12706>
> _______________________________________
>
History
Date User Action Args
2018-01-25 05:01:57mawidjajsetstage: needs patch -> patch review
pull_requests: + pull_request5156
2018-01-04 21:03:33εσχατοκυριοςsetmessages: + msg309482
2017-12-29 18:55:47mawidjajsetnosy: + mawidjaj
messages: + msg309186
2016-10-05 10:06:39berker.peksagsetversions: + Python 3.5, Python 3.6, Python 3.7, - Python 2.7, Python 3.2, Python 3.3
nosy: + berker.peksag

messages: + msg278116

keywords: + easy
2014-06-07 21:12:41εσχατοκυριοςsetfiles: + patch.patch

nosy: + εσχατοκυριος
messages: + msg219975

keywords: + patch
2011-08-12 17:47:28terry.reedysetcomponents: + Documentation
2011-08-07 08:33:16orsenthilsettitle: timeout sentinel in ftplib and poplib -> timeout sentinel in ftplib and poplib documentation
2011-08-07 08:33:00orsenthilcreate