➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2011-08-07 08:33 by orsenthil, last changed 2022-04-11 14:57 by admin.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| patch.patch | εσχατοκυριος, 2014-06-07 21:12 | review | ||
| Pull Requests | |||
|---|---|---|---|
| URL | Status | Linked | Edit |
| PR 5309 | open | mawidjaj, 2018-01-25 05:01 | |
| Messages (5) | |||
|---|---|---|---|
| msg141740 - (view) | Author: Senthil Kumaran (orsenthil) *  |
Date: 2011-08-07 08:33 | |
- ftplib and poplib, has them as timeout=None, while they default
to socket._GLOBAL_DEFAULT_TIMEOUT object.
This is wrong; someone may pass None thinking it will trigger the
default behaviour, and have nasty surprises.
|
|||
| msg219975 - (view) | Author: Greg (εσχατοκυριος) * | Date: 2014-06-07 21:12 | |
In the definition of FTP.connect(), I've changed the code to actually use None as a lack-of-explicit-timeout sentinel instead of -999. For FTP and FTP_TLS, I've changed the documentation to reflect what the code is doing. |
|||
| msg278116 - (view) | Author: Berker Peksag (berker.peksag) * |
Date: 2016-10-05 10:06 | |
Documentation changes look good to me. However, I'd prefer using socket._GLOBAL_DEFAULT_TIMEOUT in the timeout parameter of FTP.connect(). |
|||
| msg309186 - (view) | Author: Marcel Widjaja (mawidjaj) * | Date: 2017-12-29 18:55 | |
Greg, I wonder if you are planning to submit a PR for your patch? If not, I'm plan to take your patch, make some minor adjustment and submit a PR. |
|||
| msg309482 - (view) | Author: Greg (εσχατοκυριος) * | Date: 2018-01-04 21:03 | |
Completely forgot about this, please take my patch and submit a pr On Fri, Dec 29, 2017 at 10:55 AM, Marcel Widjaja <report@bugs.python.org> wrote: > > Marcel Widjaja <mwidj@yahoo.com> added the comment: > > Greg, I wonder if you are planning to submit a PR for your patch? If not, > I'm plan to take your patch, make some minor adjustment and submit a PR. > > ---------- > nosy: +mawidjaj > > _______________________________________ > Python tracker <report@bugs.python.org> > <https://bugs.python.org/issue12706> > _______________________________________ > |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:20 | admin | set | github: 56915 |
| 2021-12-01 23:38:41 | iritkatriel | set | versions: + Python 3.9, Python 3.10, Python 3.11, - Python 3.5, Python 3.6, Python 3.7 |
| 2018-01-25 05:01:57 | mawidjaj | set | stage: needs patch -> patch review pull_requests: + pull_request5156 |
| 2018-01-04 21:03:33 | εσχατοκυριος | set | messages: + msg309482 |
| 2017-12-29 18:55:47 | mawidjaj | set | nosy:
+ mawidjaj messages: + msg309186 |
| 2016-10-05 10:06:39 | berker.peksag | set | versions:
+ Python 3.5, Python 3.6, Python 3.7, - Python 2.7, Python 3.2, Python 3.3 nosy: + berker.peksag messages: + msg278116 keywords: + easy |
| 2014-06-07 21:12:41 | εσχατοκυριος | set | files:
+ patch.patch nosy: + εσχατοκυριος messages: + msg219975 keywords: + patch |
| 2011-08-12 17:47:28 | terry.reedy | set | components: + Documentation |
| 2011-08-07 08:33:16 | orsenthil | set | title: timeout sentinel in ftplib and poplib -> timeout sentinel in ftplib and poplib documentation |
| 2011-08-07 08:33:00 | orsenthil | create | |