classification
Title: Incorrect test code in test_logging.py
Type: Stage:
Components: Tests Versions: Python 3.3
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: vinay.sajip Nosy List: santoso.wijaya, scoder, vinay.sajip
Priority: normal Keywords: patch

Created on 2011-04-21 19:24 by scoder, last changed 2011-04-21 23:20 by vinay.sajip. This issue is now closed.

Files
File name Uploaded Description Edit
issue11903_py33.patch santoso.wijaya, 2011-04-21 20:10 review
Messages (4)
msg134239 - (view) Author: Stefan Behnel (scoder) * (Python committer) Date: 2011-04-21 19:24
In test file test_logging.py, around line 2359, list.append() is called with two arguments instead of one. I suppose it is meant to be called with a tuple.

class ModuleLevelMiscTest(BaseTest):
    [...]
    def _test_log(self, method, level=None):
        called = []
        patch(self, logging, 'basicConfig',
              lambda *a, **kw: called.append(a, kw))  # <====
msg134243 - (view) Author: Santoso Wijaya (santoso.wijaya) * Date: 2011-04-21 20:00
Introduced in changeset c7f7672b70a9.
msg134246 - (view) Author: Santoso Wijaya (santoso.wijaya) * Date: 2011-04-21 20:10
Simple fix.
msg134257 - (view) Author: Vinay Sajip (vinay.sajip) * (Python committer) Date: 2011-04-21 23:20
Checked in, see changeset fecf9e6d7630 - thanks.
History
Date User Action Args
2011-04-21 23:20:14vinay.sajipsetstatus: open -> closed

nosy: + vinay.sajip
messages: + msg134257

assignee: vinay.sajip
resolution: fixed
2011-04-21 20:10:21santoso.wijayasetfiles: + issue11903_py33.patch
keywords: + patch
messages: + msg134246
2011-04-21 20:00:17santoso.wijayasetnosy: + santoso.wijaya
messages: + msg134243
2011-04-21 19:24:11scodercreate