Title: increase xml.dom.minidom test coverage
Type: Stage: commit review
Components: Tests, XML Versions: Python 3.2, Python 3.3, Python 2.7
Status: closed Resolution: accepted
Dependencies: Superseder:
Assigned To: rhettinger Nosy List: brian.curtin, mdorn, python-dev, rhettinger, sandro.tosi
Priority: normal Keywords: patch

Created on 2011-04-04 04:47 by mdorn, last changed 2011-06-25 13:56 by rhettinger. This issue is now closed.

File name Uploaded Description Edit
increase_minidom_test_coverage.patch mdorn, 2011-04-04 04:47
Messages (3)
msg132915 - (view) Author: (mdorn) Date: 2011-04-04 04:47
Added some tests to ensure xml.dom.NotFoundErr where appropriate, and for a handful of previously untested methods.  Increased coverage from 52% to 53%.
msg139059 - (view) Author: Sandro Tosi (sandro.tosi) * (Python committer) Date: 2011-06-25 13:18
I checked the patch, and it works (in 2.7, 3.2 and default) and it would be nice if it can be committed.
msg139066 - (view) Author: Roundup Robot (python-dev) Date: 2011-06-25 13:54
New changeset 79d61e2050cd by Raymond Hettinger in branch 'default':
Issue 11758: increase xml.dom.minidom test coverage (contributed by mdorn, reviewed by Sandro Tosi).
Date User Action Args
2011-06-25 13:56:00rhettingersetstatus: open -> closed
resolution: accepted
2011-06-25 13:54:59python-devsetnosy: + python-dev
messages: + msg139066
2011-06-25 13:31:49sandro.tosisetassignee: rhettinger

nosy: + rhettinger
2011-06-25 13:18:43sandro.tosisetversions: + Python 2.7, Python 3.2
nosy: + sandro.tosi

messages: + msg139059

stage: commit review
2011-04-04 16:12:40brian.curtinsetnosy: + brian.curtin
2011-04-04 04:47:13mdorncreate