➜
This issue tracker has been migrated to GitHub,
and is currently read-only.
For more information,
see the GitHub FAQs in the Python's Developer Guide.
Created on 2011-03-17 07:04 by knicker.kicker, last changed 2022-04-11 14:57 by admin. This issue is now closed.
| Files | ||||
|---|---|---|---|---|
| File name | Uploaded | Description | Edit | |
| 20110317_ceval.patch | knicker.kicker, 2011-03-17 07:04 | |||
| Messages (5) | |||
|---|---|---|---|
| msg131230 - (view) | Author: knickerkicker (knicker.kicker) | Date: 2011-03-17 07:04 | |
Replaced boilerplate implementations of several BINARY_* and INPLACE_* opcodes with two macros. The result shaves off 154 lines from Python/ceval.c. |
|||
| msg131250 - (view) | Author: Amaury Forgeot d'Arc (amaury.forgeotdarc) *  |
Date: 2011-03-17 14:01 | |
Hmm, this kind of macros make it difficult to step line by line in a debugger. From this point of view, an inlined function would be better, I'm not sure if this can have a performance impact though. |
|||
| msg131283 - (view) | Author: knickerkicker (knicker.kicker) | Date: 2011-03-17 21:09 | |
Creating a inline function would require passing the stackpointer variable so that the TOP() and POP() macros continue working, and creating variables for u, v and x. I am not sure if that will not have a performance impact - ideally it shouldn't, but can we trust the compilers to see what we're upto? Also, the DISPATCH() macro will still need to be outside the inline function. |
|||
| msg131285 - (view) | Author: Raymond Hettinger (rhettinger) * |
Date: 2011-03-17 21:29 | |
-1 I think this will make the code harder to understand and maintain. |
|||
| msg246226 - (view) | Author: A.M. Kuchling (akuchling) * |
Date: 2015-07-03 22:12 | |
Closing, because neither Amaury nor Raymond likes the idea. Thanks for your work, anyway! |
|||
| History | |||
|---|---|---|---|
| Date | User | Action | Args |
| 2022-04-11 14:57:14 | admin | set | github: 55791 |
| 2015-07-03 22:12:16 | akuchling | set | status: open -> closed nosy: + akuchling messages: + msg246226 resolution: rejected stage: resolved |
| 2014-10-04 21:35:54 | francismb | set | type: enhancement |
| 2011-03-17 21:29:33 | rhettinger | set | priority: normal -> low nosy: rhettinger, amaury.forgeotdarc, pitrou, knicker.kicker versions: - Python 3.1, Python 3.2, Python 3.4 |
| 2011-03-17 21:29:07 | rhettinger | set | nosy:
+ rhettinger messages: + msg131285 |
| 2011-03-17 21:09:33 | knicker.kicker | set | messages: + msg131283 |
| 2011-03-17 14:16:27 | pitrou | set | nosy:
+ pitrou |
| 2011-03-17 14:01:23 | amaury.forgeotdarc | set | nosy:
+ amaury.forgeotdarc messages: + msg131250 |
| 2011-03-17 07:04:02 | knicker.kicker | create | |