This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: future warning in commets
Type: enhancement Stage:
Components: Interpreter Core Versions:
Status: closed Resolution: rejected
Dependencies: Superseder:
Assigned To: lemburg Nosy List: doerwalter, lemburg, makaron, mcherm
Priority: normal Keywords:

Created on 2005-02-18 21:10 by makaron, last changed 2022-04-11 14:56 by admin. This issue is now closed.

Messages (5)
msg54398 - (view) Author: Grzegorz Makarewicz (makaron) Date: 2005-02-18 21:10
Python uses '#' as start of comment, generally these
lines can (should) be ignored by python compiler but ..
deprecation warnings are issued when comment contains
non ascii letters - ord(ch) not in range 0-127

can we disable it in this situation ?
msg54399 - (view) Author: Walter Dörwald (doerwalter) * (Python committer) Date: 2005-02-21 09:17
Logged In: YES 

I don't think we should change this. The encoding is
something that affects the whole file not just the
executable part of it. When a file that claims to be ASCII
contains bytes > 0x7f there's something fishy going on, no
matter where these bytes are.
msg54400 - (view) Author: Michael Chermside (mcherm) (Python triager) Date: 2005-02-23 13:33
Logged In: YES 

I agree with doerwalter. If the file is in ascii, then it
should be in ascii... even comments. If it's not in ascii,
that's fine, but it needs to be marked as to what encoding
it IS in. I don't happen to know of any encodings in which
certain bytes with the high bit set indicate newlines, but
imagine that there were one. The newline marks the end of
the comment, so it makes a syntactic difference in the
program... we must be able to recognize newlines in order to
parse the file. And if we don't know the encoding, then how
can we possibly recognize newlines?

I propose rejecting the patch.
msg54401 - (view) Author: Marc-Andre Lemburg (lemburg) * (Python committer) Date: 2005-02-23 13:44
Logged In: YES 

+1, this request is not in line with the source code
encoding PEP.
Rejecting the request.
msg54402 - (view) Author: Michael Chermside (mcherm) (Python triager) Date: 2005-12-28 16:41
Logged In: YES 

Rejecting, as per lemburg.
Date User Action Args
2022-04-11 14:56:09adminsetgithub: 41600
2005-02-18 21:10:06makaroncreate