classification
Title: OS X installer build script for 3.2 can no longer build with system Python on OS X 10.5
Type: Stage: resolved
Components: Build, macOS Versions: Python 3.2, Python 2.7
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: ned.deily Nosy List: georg.brandl, ned.deily, rhettinger, ronaldoussoren
Priority: Keywords: patch

Created on 2011-01-29 03:47 by ned.deily, last changed 2011-01-30 01:51 by ned.deily. This issue is now closed.

Files
File name Uploaded Description Edit
issue_synch_installer_py3k.patch ned.deily, 2011-01-29 03:47
Messages (5)
msg127377 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2011-01-29 03:47
During the 3.2rc1 release cycle, it was discovered that it was no longer possible to build the 32-bit installer on OS X 10.5 as customary with the system Python 2.5 due to an inadvertent 2.6 feature ("with") added to the OS X installer build script.  This unnecessarily complicates the installer build process and violates past attempts to keep the installer script buildable with the system Python and compatible across current Python 2.x and 3.x releases.  The attached patch to the installer script removes the "with", properly guards a new Python 3 only build step, and updates the comments and README file.  The patched build script has been tested on both OS X 10.5 and 10.6.  This patch should be included in 3.2rc2.
msg127380 - (view) Author: Raymond Hettinger (rhettinger) * (Python committer) Date: 2011-01-29 04:37
+1 for reversion.
msg127385 - (view) Author: Georg Brandl (georg.brandl) * (Python committer) Date: 2011-01-29 09:19
Looks okay to me (and any bugs are likely to become apparent when the installers are built...)
msg127464 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2011-01-29 18:58
Committed in r88235 for 3.2rc2 with release manager approval.
Pending 2.7 backport.
msg127505 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2011-01-30 01:51
Merged to 2.7 in r88248 (for 2.7.2).
History
Date User Action Args
2011-01-30 01:51:27ned.deilysetstatus: pending -> closed
nosy: georg.brandl, rhettinger, ronaldoussoren, ned.deily
messages: + msg127505
2011-01-29 18:58:05ned.deilysetstatus: open -> pending
priority: release blocker ->

versions: + Python 2.7
nosy: georg.brandl, rhettinger, ronaldoussoren, ned.deily
messages: + msg127464
resolution: fixed
stage: patch review -> resolved
2011-01-29 09:19:52georg.brandlsetnosy: georg.brandl, rhettinger, ronaldoussoren, ned.deily
messages: + msg127385
2011-01-29 04:37:37rhettingersetnosy: + rhettinger
messages: + msg127380
2011-01-29 03:47:07ned.deilycreate