This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

classification
Title: regrtest - allow for relative path with --coverdir
Type: behavior Stage: resolved
Components: Tests Versions: Python 3.3
process
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: sandro.tosi Nosy List: python-dev, r.david.murray, sandro.tosi
Priority: low Keywords: patch

Created on 2011-01-27 18:48 by sandro.tosi, last changed 2022-04-11 14:57 by admin. This issue is now closed.

Files
File name Uploaded Description Edit
regrtest_coverdir_relative_path-py3k.patch sandro.tosi, 2011-01-27 18:48
Messages (3)
msg127207 - (view) Author: Sandro Tosi (sandro.tosi) * (Python committer) Date: 2011-01-27 18:48
Hi, following up msg127157 here's a patch to allow for relative path when using --coverdir.

The current solution uses getcwd() but since CWD is replaced by a temporary location before calling main(), then the resulting dir is in an unexpected location.

using support.SAVECWD we use the saved CWD that's where the script is executed, so the relative path is created/used where expected.
msg132014 - (view) Author: Roundup Robot (python-dev) (Python triager) Date: 2011-03-24 18:35
New changeset 6ff4e479f03b by R David Murray in branch 'default':
#11030: make --coverdir work for relative directories again.
http://hg.python.org/cpython/rev/6ff4e479f03b
msg132015 - (view) Author: R. David Murray (r.david.murray) * (Python committer) Date: 2011-03-24 18:37
Thanks.  Shortened patch by using the fact that os.path.join returns the second component if it is absolute, as discussed on IRC.
History
Date User Action Args
2022-04-11 14:57:11adminsetgithub: 55239
2011-03-24 18:37:05r.david.murraysetstatus: open -> closed

type: behavior

nosy: + r.david.murray
messages: + msg132015
resolution: fixed
stage: patch review -> resolved
2011-03-24 18:35:47python-devsetnosy: + python-dev
messages: + msg132014
2011-01-27 18:48:56sandro.tosicreate