This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: 3.2 Makefile changes for versioned scripts break OS X framework installs
Type: Stage: resolved
Components: Build, macOS Versions: Python 3.2
Status: closed Resolution: fixed
Dependencies: Superseder:
Assigned To: ned.deily Nosy List: georg.brandl, ixokai, ned.deily, pitrou, ronaldoussoren
Priority: release blocker Keywords: patch

Created on 2011-01-04 07:18 by ned.deily, last changed 2022-04-11 14:57 by admin. This issue is now closed.

File name Uploaded Description Edit
issue10820-py3k.patch ned.deily, 2011-01-04 07:21
Messages (6)
msg125295 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2011-01-04 07:18
The changes for Issue10679 (r87525) to installed versioned scripts break OS X framework installs.  The install_versionedtools target in Mac/Makefile already did most of this work and is now superfluous.  The attached patch fixes the problem.
msg125916 - (view) Author: Stephen Hansen (ixokai) (Python triager) Date: 2011-01-10 19:36
FYI, The patch applied cleanly to branches/py3k; I then built a framework build (universal), installed it and ran the test-suite.

I had two failures, but I don't know if either is related. The first was the tk tests didn't pass, but I'm not sure if there was something special I need to do to get tk compiled universal in a framework build-- I'll look into it.

But this one perplexes me:

Wimp:build pythonbuildbot$ ./python.exe -m test.regrtest test_site
[1/1] test_site
test test_site failed -- Traceback (most recent call last):
  File "/Users/pythonbuildbot/32test/build/Lib/test/", line 225, in test_getsitepackages
    self.assertEqual(len(dirs), 2)
AssertionError: 3 != 2

1 test failed:
Wimp:build pythonbuildbot$ ./python.exe
Python 3.2b2+ (py3k:87899M, Jan 10 2011, 11:08:48) 
[GCC 4.0.1 (Apple Inc. build 5493)] on darwin
Type "help", "copyright", "credits" or "license" for more information.
>>> import site
>>> site.getsitepackages()
['/Library/Frameworks/Python.framework/Versions/3.2/lib/python3.2/site-packages', '/Library/Frameworks/Python.framework/Versions/3.2/lib/site-python', '/Library/Python/3.2/site-packages']

This machine fwiw never had any Python 3.x installed anywhere: in fact it was an almost pure stock 10.5 with buildbots put on it.
msg125917 - (view) Author: Antoine Pitrou (pitrou) * (Python committer) Date: 2011-01-10 19:42
Looks like an issue in test_site rather than itself (which has dedicated code to add a third site directory under framework builds). The test_site failure is not enough to hold the release, IMO.

Given Ronald's absence, I think Ned could start exercising his commit rights on this one. Ned, you'll need to write a Misc/NEWS entry in the "build" section (reverse chronological order). And an appropriate commit message. I think you'll figure out the (loose) typographical conventions :-)
msg125918 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2011-01-10 19:52
Thanks for trying a build.  There are various tk test failures possible depending on what version of Tcl/Tk is or isn't installed, so I wouldn't be concerned about them.  The test_site failure is also not new. It is documented in re-opened Issue8084.
msg125922 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2011-01-10 19:59
(BTW, I was planning to see what we could do about Issue8084 before release anyway.  I'll get on it.)
msg125939 - (view) Author: Ned Deily (ned.deily) * (Python committer) Date: 2011-01-10 22:16
Fixed in r87908.
Date User Action Args
2022-04-11 14:57:10adminsetgithub: 55029
2011-01-10 22:16:03ned.deilysetstatus: open -> closed
nosy: georg.brandl, ixokai, ronaldoussoren, pitrou, ned.deily
messages: + msg125939

resolution: fixed
stage: patch review -> resolved
2011-01-10 19:59:33ned.deilysetnosy: georg.brandl, ixokai, ronaldoussoren, pitrou, ned.deily
messages: + msg125922
2011-01-10 19:52:22ned.deilysetnosy: georg.brandl, ixokai, ronaldoussoren, pitrou, ned.deily
messages: + msg125918
2011-01-10 19:42:55pitrousetassignee: ronaldoussoren -> ned.deily

messages: + msg125917
nosy: + pitrou
2011-01-10 19:36:48ixokaisetnosy: + ixokai
messages: + msg125916
2011-01-04 07:21:00ned.deilysetfiles: + issue10820-py3k.patch
keywords: + patch
2011-01-04 07:18:54ned.deilycreate