This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: readline does not need termcap
Type: Stage:
Components: Library (Lib) Versions: Python 2.4
Status: closed Resolution: out of date
Dependencies: Superseder:
Assigned To: Nosy List: loewis, nijel
Priority: normal Keywords: patch

Created on 2004-12-01 15:32 by nijel, last changed 2022-04-11 14:56 by admin. This issue is now closed.

File name Uploaded Description Edit
Python-2.3.3-termcap.patch nijel, 2004-12-01 15:32
Python-2.4-readline.patch nijel, 2004-12-06 22:48
Messages (6)
msg47350 - (view) Author: Michal Čihař (nijel) * Date: 2004-12-01 15:32
Readline doesn't need -ltermcap (at least on some
systems), so configure check should deal with this.
Attached patch completely removes -ltermcap, however
better might be to check both possibilities.

Patch is against 2.3.3, however it applies to 2.4 also.
msg47351 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2004-12-05 18:59
Logged In: YES 

The patch is incorrect. As you suggest yourself, readline
*does* need -ltermcap on some systems; this patch breaks
these systems. Rejecting the patch. If you can come up with
a patch that performs an autoconf test first, please submit
a new patch.
msg47352 - (view) Author: Michal Čihař (nijel) * Date: 2004-12-06 11:18
Logged In: YES 

Okay, here is IMHO correct patch, which does more or less
same as does for finding needed libraries.
msg47353 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2004-12-06 22:29
Logged In: YES 

This patch is still incorrect. It breaks on systems where
readline requires termcap, e.g. Solaris.
msg47354 - (view) Author: Michal Čihař (nijel) * Date: 2004-12-06 22:48
Logged In: YES 

Ooops, I should better read what I write, there shouldn't be
twice ncurses, once it should be termcap.... Sorry.
msg47355 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2006-11-22 08:58
I think this patch is obsolete since r41945; closing it as out-of-date.
Date User Action Args
2022-04-11 14:56:08adminsetgithub: 41267
2004-12-01 15:32:12nijelcreate