classification
Title: test_shutil fails on Windows after r86733
Type: behavior Stage: resolved
Components: Library (Lib), Windows Versions: Python 3.2
process
Status: closed Resolution: works for me
Dependencies: Superseder:
Assigned To: brian.curtin Nosy List: brian.curtin, tarek
Priority: normal Keywords: patch

Created on 2010-11-26 16:00 by brian.curtin, last changed 2011-04-20 00:55 by brian.curtin. This issue is now closed.

Files
File name Uploaded Description Edit
issue10540.diff brian.curtin, 2010-11-26 16:53 review
Messages (3)
msg122462 - (view) Author: Brian Curtin (brian.curtin) * (Python committer) Date: 2010-11-26 16:00
My build slave shows a test failure at test_dont_copy_file_onto_link_to_itself. This happens because the implementation of _samefile in Lib/shutil.py (line 70) doesn't work for Windows hard links.

Patch on the way.
msg122466 - (view) Author: Brian Curtin (brian.curtin) * (Python committer) Date: 2010-11-26 16:53
Here is a patch.

os.path.samefile and hard links don't work for Windows the same way they do for Mac/Linux. In the case where we are on Windows and a link comes into the _samefile function, check that it's a link and then use os.path.sameopenfile. If it's not a link but a regular file, or it's some other OS, do the os.path.samefile check.
msg134115 - (view) Author: Brian Curtin (brian.curtin) * (Python committer) Date: 2011-04-20 00:55
This hasn't been an issue for quite some time, and I suspect the follow-up work on symbolic and hard links and their supporting functions corrected any problems in this area.
History
Date User Action Args
2011-04-20 00:55:10brian.curtinsetstatus: open -> closed
resolution: works for me
messages: + msg134115

stage: needs patch -> resolved
2010-11-26 16:53:44brian.curtinsetfiles: + issue10540.diff

nosy: + tarek
messages: + msg122466

keywords: + patch
2010-11-26 16:00:33brian.curtincreate