classification
Title: [patch] Add 2to3 support for displaying warnings as Python comments
Type: enhancement Stage: test needed
Components: 2to3 (2.x to 3.x conversion tool) Versions: Python 3.3, Python 3.4, Python 2.7
process
Status: open Resolution:
Dependencies: Superseder:
Assigned To: collinwinter Nosy List: adrianholovaty, benjamin.peterson, brian.curtin, collinwinter, eric.araujo
Priority: normal Keywords: patch

Created on 2007-08-27 02:20 by adrianholovaty, last changed 2014-03-14 22:44 by eric.araujo.

Files
File name Uploaded Description Edit
2to3_insert_comment.diff adrianholovaty, 2007-08-27 02:20
2to3_comment_warnings.diff adrianholovaty, 2007-08-27 02:21
issue1034.diff brian.curtin, 2010-01-07 04:29 patch against r77336
Messages (6)
msg55331 - (view) Author: Adrian Holovaty (adrianholovaty) Date: 2007-08-27 02:20
Per a Python-3000 mailing list discussion here --
http://mail.python.org/pipermail/python-3000/2007-August/009835.html --
I have implemented an addition to the 2to3 utility that enables warnings
to be output as comments in Python source code instead of being logged
to stdout.

See the attached patch and a description of the changes here:
http://mail.python.org/pipermail/python-3000/2007-August/009881.html
msg55332 - (view) Author: Adrian Holovaty (adrianholovaty) Date: 2007-08-27 02:21
I'm also attaching 2to3_comment_warnings.diff, which is an example of
how we could integrate the insert_comment() method from the first patch
to replace the current functionality of fixes.basefix.BaseFix.warning().
msg73152 - (view) Author: Benjamin Peterson (benjamin.peterson) * (Python committer) Date: 2008-09-12 23:11
On the patch:
1. I think both a log message and the comment should be written. The
point needs to be reinforced to users.
2. I'd like to see some tests.
3. Maybe an option to turn the auto comments off?


This is interesting. I'd like to have someone else weigh in before it is
applied though.
msg97342 - (view) Author: Brian Curtin (brian.curtin) * (Python committer) Date: 2010-01-07 04:29
I think this would be a good addition so I took Adrian's patch and brought it up to date. I'll need to expand the testing, but I think Benjamin's 1 and 3 are covered.
msg116774 - (view) Author: Mark Lawrence (BreamoreBoy) * Date: 2010-09-18 13:13
Removed 2.7 as too late, can we get this into 3.2?
msg213599 - (view) Author: Éric Araujo (eric.araujo) * (Python committer) Date: 2014-03-14 22:44
(2to3 is an exception and can get improvements in stable versions.)
History
Date User Action Args
2014-03-14 22:44:09eric.araujosetnosy: + eric.araujo

messages: + msg213599
versions: + Python 2.7, Python 3.3, Python 3.4, - Python 3.2
2014-02-03 19:42:48BreamoreBoysetnosy: - BreamoreBoy
2010-09-18 13:13:45BreamoreBoysetnosy: + BreamoreBoy

messages: + msg116774
versions: - Python 2.7
2010-01-07 14:29:47brian.curtinsettype: enhancement
2010-01-07 04:31:10brian.curtinsetstage: test needed
versions: + Python 2.7, Python 3.2, - Python 3.0
2010-01-07 04:29:09brian.curtinsetfiles: + issue1034.diff
nosy: + brian.curtin
messages: + msg97342

2008-09-12 23:11:06benjamin.petersonsetnosy: + benjamin.peterson
messages: + msg73152
2008-01-06 22:29:44adminsetkeywords: - py3k
versions: Python 3.0
2007-11-23 08:27:36christian.heimessetkeywords: + py3k
versions: + Python 3.0
2007-09-17 08:26:29jafosetpriority: normal
2007-09-06 17:58:56collinwintersetassignee: collinwinter
components: + 2to3 (2.x to 3.x conversion tool), - Demos and Tools
nosy: + collinwinter
2007-09-02 20:09:16loewissetkeywords: + patch
2007-08-27 02:21:54adrianholovatysetfiles: + 2to3_comment_warnings.diff
messages: + msg55332
2007-08-27 02:20:52adrianholovatycreate