This issue tracker has been migrated to GitHub, and is currently read-only.
For more information, see the GitHub FAQs in the Python's Developer Guide.

Title: socketmodule on OpenBSD/sparc64 (64bit machine)
Type: Stage:
Components: None Versions:
Status: closed Resolution: rejected
Dependencies: Superseder:
Assigned To: Nosy List: loewis, pelotas
Priority: normal Keywords: patch

Created on 2004-08-01 19:33 by pelotas, last changed 2022-04-11 14:56 by admin. This issue is now closed.

File name Uploaded Description Edit
patch-Modules_socketmodule_c pelotas, 2004-08-01 19:33 Another s/unsigned long/int/
Messages (3)
msg46502 - (view) Author: Aleksander Piotrowski (pelotas) Date: 2004-08-01 19:33
In revision 1.280 of Modules/socketmodule.c, perky has
fixed some problems of socketmodule on 64bit arches. On
my OpenBSD/sparc64 (SUN Ultra 10) this change is not
enough. Attached patch (which is currently part of
python port for OpenBSD) is necessary.

In private mail, perky said that this change might be
OK for OpenBSD but doesn't work for other OSes.

Attached diff is against 2.3.4.

BTW this another unsigned long to int change doesn't
break OpenBSD/i386.
msg46503 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2004-08-01 23:11
Logged In: YES 

This patch is incorrect. On your system, I believe,
inet_addr does not return int, but in_addr_t. Therefore, you
should write an autoconf test that tests whether in_addr_t
is available on the system. If the type is not available,
check whether unsigned long int has size 4. If it doesn't,
check whether unsigned int has size 4. Of these three types,
use the first one that matches; generate an #error if you
can't find a suitable type.
msg46504 - (view) Author: Martin v. Löwis (loewis) * (Python committer) Date: 2004-08-26 21:50
Logged In: YES 

Rejecting the patch.
Date User Action Args
2022-04-11 14:56:06adminsetgithub: 40669
2004-08-01 19:33:07pelotascreate