diff --git a/_collections_abc.py b/_collections_abc.py index 005d884..f379d09 100644 --- a/_collections_abc.py +++ b/_collections_abc.py @@ -691,7 +691,7 @@ class Mapping(Collection): Mapping.register(mappingproxy) -class MappingView(Sized): +class MappingView(Collection): __slots__ = '_mapping', diff --git a/test/test_collections.py b/test/test_collections.py index 47f7562..c462694 100644 --- a/test/test_collections.py +++ b/test/test_collections.py @@ -784,13 +784,13 @@ class TestOneTrickPonyABCs(ABCTestCase): self.assertFalse(issubclass(type(x), Collection), repr(type(x))) # Check some non-collection iterables non_col_iterables = [_test_gen(), iter(b''), iter(bytearray()), - (x for x in []), dict().values()] + (x for x in [])] for x in non_col_iterables: self.assertNotIsInstance(x, Collection) self.assertFalse(issubclass(type(x), Collection), repr(type(x))) # Check some collections - samples = [set(), frozenset(), dict(), bytes(), str(), tuple(), - list(), dict().keys(), dict().items()] + samples = [set(), frozenset(), dict(), bytes(), str(), tuple(), list(), + dict().keys(), dict().values(), dict().items()] for x in samples: self.assertIsInstance(x, Collection) self.assertTrue(issubclass(type(x), Collection), repr(type(x)))