diff -r 8de6b5198c5a Doc/library/signal.rst --- a/Doc/library/signal.rst Fri Mar 20 01:55:04 2015 +0100 +++ b/Doc/library/signal.rst Fri Mar 20 02:12:13 2015 +0100 @@ -422,6 +422,11 @@ The :mod:`signal` module defines the fol .. versionadded:: 3.3 + .. versionchanged:: 3.5 + The function is now retried with the recomputed timeout if interrupted by + a signal not in *sigset*, if the signal handler does not raise an + exception (see :pep:`475` for the rationale). + .. _signal-example: diff -r 8de6b5198c5a Lib/test/eintrdata/eintr_tester.py --- a/Lib/test/eintrdata/eintr_tester.py Fri Mar 20 01:55:04 2015 +0100 +++ b/Lib/test/eintrdata/eintr_tester.py Fri Mar 20 02:12:13 2015 +0100 @@ -12,6 +12,7 @@ import io import os import signal import socket +import threading import time import unittest @@ -264,11 +265,23 @@ class TimeEINTRTest(EINTRBaseTest): self.assertGreaterEqual(dt, self.sleep_time) +@unittest.skipUnless(hasattr(signal, "setitimer"), "requires setitimer()") +class SignalEINTRTest(EINTRBaseTest): + """ EINTR tests for the signal module. """ + + def test_sigtimedwait(self): + t0 = time.monotonic() + signal.sigtimedwait([], self.sleep_time) + dt = time.monotonic() - t0 + self.assertGreaterEqual(dt, self.sleep_time) + + def test_main(): support.run_unittest( OSEINTRTest, SocketEINTRTest, - TimeEINTRTest) + TimeEINTRTest, + SignalEINTRTest) if __name__ == "__main__": diff -r 8de6b5198c5a Modules/signalmodule.c --- a/Modules/signalmodule.c Fri Mar 20 01:55:04 2015 +0100 +++ b/Modules/signalmodule.c Fri Mar 20 02:12:13 2015 +0100 @@ -962,25 +962,19 @@ Returns a struct_siginfo containing info static PyObject * signal_sigtimedwait(PyObject *self, PyObject *args) { - PyObject *signals, *timeout; - struct timespec buf; + PyObject *signals; + double timeout, frac; + struct timespec ts; sigset_t set; siginfo_t si; - time_t tv_sec; - long tv_nsec; - int err; + int res; + _PyTime_timeval deadline, monotonic; - if (!PyArg_ParseTuple(args, "OO:sigtimedwait", + if (!PyArg_ParseTuple(args, "Od:sigtimedwait", &signals, &timeout)) return NULL; - if (_PyTime_ObjectToTimespec(timeout, &tv_sec, &tv_nsec, - _PyTime_ROUND_DOWN) == -1) - return NULL; - buf.tv_sec = tv_sec; - buf.tv_nsec = tv_nsec; - - if (buf.tv_sec < 0 || buf.tv_nsec < 0) { + if (timeout < 0) { PyErr_SetString(PyExc_ValueError, "timeout must be non-negative"); return NULL; } @@ -988,15 +982,38 @@ signal_sigtimedwait(PyObject *self, PyOb if (iterable_to_sigset(signals, &set)) return NULL; - Py_BEGIN_ALLOW_THREADS - err = sigtimedwait(&set, &si, &buf); - Py_END_ALLOW_THREADS - if (err == -1) { - if (errno == EAGAIN) - Py_RETURN_NONE; - else - return PyErr_SetFromErrno(PyExc_OSError); - } + _PyTime_monotonic(&deadline); + _PyTime_AddDouble(&deadline, timeout, _PyTime_ROUND_UP); + + do { + frac = fmod(timeout, 1.0); + timeout = floor(timeout); + ts.tv_sec = (long)timeout; + ts.tv_nsec = (long)(frac*1e9); + + Py_BEGIN_ALLOW_THREADS + res = sigtimedwait(&set, &si, &ts); + Py_END_ALLOW_THREADS + + if (res != -1) + break; + + if (errno != EINTR) { + if (errno == EAGAIN) + Py_RETURN_NONE; + else + return PyErr_SetFromErrno(PyExc_OSError); + } + + /* sigtimedwait() was interrupted by a signal (EINTR) */ + if (PyErr_CheckSignals()) + return NULL; + + _PyTime_monotonic(&monotonic); + timeout = _PyTime_INTERVAL(monotonic, deadline); + if (timeout <= 0.0) + break; + } while (1); return fill_siginfo(&si); }