diff -r b9623fa5a0dd Lib/test/test_os.py --- a/Lib/test/test_os.py Thu Oct 24 09:47:10 2013 -0700 +++ b/Lib/test/test_os.py Thu Oct 24 11:44:26 2013 -0700 @@ -1559,6 +1559,52 @@ @unittest.skipUnless(sys.platform == "win32", "Win32 specific tests") +class Win32ListdirTests(unittest.TestCase): + """Test listdir on Windows.""" + + def setUp(self): + self.created_paths = [] + for i in range(2): + dir_name = 'SUB%d' % i + dir_path = os.path.join(support.TESTFN, dir_name) + file_name = 'FILE%d' % i + file_path = os.path.join(support.TESTFN, file_name) + os.makedirs(dir_path) + with open(file_path, 'w') as f: + f.write("I'm %s and proud of it. Blame test_os.\n" % file_path) + self.created_paths.extend([dir_name, file_name]) + self.created_paths.sort() + + def tearDown(self): + shutil.rmtree(support.TESTFN) + + def test_listdir_no_extended_path(self): + """Test when the path is not an "extended" path.""" + # unicode + self.assertEqual( + sorted(os.listdir(support.TESTFN)), + self.created_paths) + # bytes + self.assertEqual( + sorted(os.listdir(os.fsencode(support.TESTFN))), + [os.fsencode(path) for path in self.created_paths]) + + def test_listdir_extended_path(self): + """Test when the path starts with '\\\\?\\'.""" + # See: http://msdn.microsoft.com/en-us/library/windows/desktop/aa365247(v=vs.85).aspx#maxpath + # unicode + path = '\\\\?\\' + os.path.abspath(support.TESTFN) + self.assertEqual( + sorted(os.listdir(path)), + self.created_paths) + # bytes + path = b'\\\\?\\' + os.fsencode(os.path.abspath(support.TESTFN)) + self.assertEqual( + sorted(os.listdir(path)), + [os.fsencode(path) for path in self.created_paths]) + + +@unittest.skipUnless(sys.platform == "win32", "Win32 specific tests") @support.skip_unless_symlink class Win32SymlinkTests(unittest.TestCase): filelink = 'filelinktest' @@ -2427,6 +2473,7 @@ PosixUidGidTests, Pep383Tests, Win32KillTests, + Win32ListdirTests, Win32SymlinkTests, NonLocalSymlinkTests, FSEncodingTests, diff -r b9623fa5a0dd Modules/posixmodule.c --- a/Modules/posixmodule.c Thu Oct 24 09:47:10 2013 -0700 +++ b/Modules/posixmodule.c Thu Oct 24 11:44:26 2013 -0700 @@ -3608,8 +3608,8 @@ wcscpy(wnamebuf, po_wchars); if (len > 0) { wchar_t wch = wnamebuf[len-1]; - if (wch != L'/' && wch != L'\\' && wch != L':') - wnamebuf[len++] = L'\\'; + if (wch != SEP && wch != ALTSEP && wch != L':') + wnamebuf[len++] = SEP; wcscpy(wnamebuf + len, L"*.*"); } if ((list = PyList_New(0)) == NULL) { @@ -3663,8 +3663,8 @@ len = path->length; if (len > 0) { char ch = namebuf[len-1]; - if (ch != SEP && ch != ALTSEP && ch != ':') - namebuf[len++] = '/'; + if (ch != '\\' && ch != '/' && ch != ':') + namebuf[len++] = '\\'; strcpy(namebuf + len, "*.*"); }