diff -r 0772ae3202a2 Doc/c-api/type.rst --- a/Doc/c-api/type.rst Fri Jun 22 14:56:24 2012 +0200 +++ b/Doc/c-api/type.rst Sat Jun 23 00:26:39 2012 +0200 @@ -85,3 +85,13 @@ their initialization. This function is responsible for adding inherited slots from a type's base class. Return ``0`` on success, or return ``-1`` and sets an exception on error. + +.. c:function:: PyObject* PyType_FromSpec(PyType_Spec *spec) + + Creates and returns a heap type object from the *spec* passed to the function. + +.. c:function:: PyObject* PyType_FromSpecWithBases(PyType_Spec *spec, PyObject *bases) + + Creates and returns a heap type object from the *spec*. In addition to that, + the created heap type contains all types contained by the *bases* tuple as base + types. This allows the caller to reference other heap types as base types. diff -r 0772ae3202a2 Include/object.h --- a/Include/object.h Fri Jun 22 14:56:24 2012 +0200 +++ b/Include/object.h Sat Jun 23 00:26:39 2012 +0200 @@ -433,6 +433,7 @@ } PyType_Spec; PyAPI_FUNC(PyObject*) PyType_FromSpec(PyType_Spec*); +PyAPI_FUNC(PyObject*) PyType_FromSpecWithBases(PyType_Spec*, PyObject*); #ifndef Py_LIMITED_API /* The *real* layout of a type object when allocated on the heap */ diff -r 0772ae3202a2 Objects/typeobject.c --- a/Objects/typeobject.c Fri Jun 22 14:56:24 2012 +0200 +++ b/Objects/typeobject.c Sat Jun 23 00:26:39 2012 +0200 @@ -48,6 +48,9 @@ static PyObject * _PyType_LookupId(PyTypeObject *type, struct _Py_Identifier *name); +static PyObject * +slot_tp_new(PyTypeObject *type, PyObject *args, PyObject *kwds); + unsigned int PyType_ClearCache(void) { @@ -2375,22 +2378,64 @@ }; PyObject * -PyType_FromSpec(PyType_Spec *spec) +PyType_FromSpecWithBases(PyType_Spec *spec, PyObject *bases) { PyHeapTypeObject *res = (PyHeapTypeObject*)PyType_GenericAlloc(&PyType_Type, 0); + PyTypeObject *type, *base; + char *s; char *res_start = (char*)res; PyType_Slot *slot; + + /* Set the type name and qualname */ + s = strrchr(spec->name, '.'); + if (s == NULL) + s = spec->name; + else + s++; if (res == NULL) return NULL; - res->ht_name = PyUnicode_FromString(spec->name); + res->ht_name = PyUnicode_FromString(s); if (!res->ht_name) goto fail; res->ht_qualname = res->ht_name; Py_INCREF(res->ht_qualname); - res->ht_type.tp_name = _PyUnicode_AsString(res->ht_name); + res->ht_type.tp_name = spec->name; if (!res->ht_type.tp_name) goto fail; + + /* Adjust for empty tuple bases */ + if (!bases) { + bases = PyTuple_Pack(1, &PyBaseObject_Type); + if (bases == NULL) + goto fail; + } + else + Py_INCREF(bases); + + /* Calculate best base, and check that all bases are type objects */ + base = best_base(bases); + if (base == NULL) { + goto fail; + } + if (!PyType_HasFeature(base, Py_TPFLAGS_BASETYPE)) { + PyErr_Format(PyExc_TypeError, + "type '%.100s' is not an acceptable base type", + base->tp_name); + goto fail; + } + + type = (PyTypeObject *)res; + /* Initialize essential fields */ + type->tp_as_number = &res->as_number; + type->tp_as_sequence = &res->as_sequence; + type->tp_as_mapping = &res->as_mapping; + type->tp_as_buffer = &res->as_buffer; + /* Set tp_base and tp_bases */ + type->tp_bases = bases; + bases = NULL; + Py_INCREF(base); + type->tp_base = base; res->ht_type.tp_basicsize = spec->basicsize; res->ht_type.tp_itemsize = spec->itemsize; @@ -2421,6 +2466,13 @@ if (PyType_Ready(&res->ht_type) < 0) goto fail; + /* Set type.__module__ */ + s = strrchr(spec->name, '.'); + if (s != NULL) + _PyDict_SetItemId(type->tp_dict, &PyId___module__, + PyUnicode_FromStringAndSize( + spec->name, (Py_ssize_t)(s - spec->name))); + return (PyObject*)res; fail: @@ -2428,6 +2480,12 @@ return NULL; } +PyObject * +PyType_FromSpec(PyType_Spec *spec) +{ + return PyType_FromSpecWithBases(spec, NULL); +} + /* Internal API to look for a name through the MRO. This returns a borrowed reference, and doesn't set an exception! */ @@ -4757,7 +4815,7 @@ object.__new__(dict). To do this, we check that the most derived base that's not a heap type is this type. */ staticbase = subtype; - while (staticbase && (staticbase->tp_flags & Py_TPFLAGS_HEAPTYPE)) + while (staticbase && (staticbase->tp_new == slot_tp_new)) staticbase = staticbase->tp_base; /* If staticbase is NULL now, it is a really weird type. In the spirit of backwards compatibility (?), just shut up. */