diff -r 388016438a50 Lib/socketserver.py --- a/Lib/socketserver.py Fri Apr 06 13:20:49 2012 -0400 +++ b/Lib/socketserver.py Fri Apr 06 23:40:08 2012 +0200 @@ -133,6 +133,7 @@ import select import sys import os +import errno try: import threading except ImportError: @@ -147,6 +148,15 @@ "ThreadingUnixStreamServer", "ThreadingUnixDatagramServer"]) +def _eintr_retry(func, *args): + """restart a system call interrupted by EINTR""" + while True: + try: + return func(*args) + except OSError as e: + if e.errno != errno.EINTR: + raise + class BaseServer: """Base class for server classes. @@ -223,7 +233,8 @@ # connecting to the socket to wake this up instead of # polling. Polling reduces our responsiveness to a # shutdown request and wastes cpu at all other times. - r, w, e = select.select([self], [], [], poll_interval) + r, w, e = _eintr_retry(select.select, [self], [], [], + poll_interval) if self in r: self._handle_request_noblock() @@ -273,7 +284,7 @@ timeout = self.timeout elif self.timeout is not None: timeout = min(timeout, self.timeout) - fd_sets = select.select([self], [], [], timeout) + fd_sets = _eintr_retry(select.select, [self], [], [], timeout) if not fd_sets[0]: self.handle_timeout() return diff -r 388016438a50 Lib/test/test_socketserver.py --- a/Lib/test/test_socketserver.py Fri Apr 06 13:20:49 2012 -0400 +++ b/Lib/test/test_socketserver.py Fri Apr 06 23:40:08 2012 +0200 @@ -8,6 +8,8 @@ import select import signal import socket +import select +import errno import tempfile import unittest import socketserver @@ -226,6 +228,38 @@ socketserver.DatagramRequestHandler, self.dgram_examine) + @contextlib.contextmanager + def mocked_select_module(self): + """Mocks the select.select() call to raise EINTR for first call""" + old_select = select.select + + class MockSelect: + def __init__(self): + self.called = 0 + + def __call__(self, *args): + self.called += 1 + if self.called == 1: + # raise the exception on first call + raise OSError(errno.EINTR, os.strerror(errno.EINTR)) + else: + # Return real select value for consecutive calls + return old_select(*args) + + select.select = MockSelect() + try: + yield select.select + finally: + select.select = old_select + + def test_InterruptServerSelectCall(self): + with self.mocked_select_module() as mock_select: + pid = self.run_server(socketserver.TCPServer, + socketserver.StreamRequestHandler, + self.stream_examine) + # Make sure select was called again: + self.assertGreater(mock_select.called, 1) + # Alas, on Linux (at least) recvfrom() doesn't return a meaningful # client address so this cannot work: diff -r 388016438a50 Misc/NEWS --- a/Misc/NEWS Fri Apr 06 13:20:49 2012 -0400 +++ b/Misc/NEWS Fri Apr 06 23:40:08 2012 +0200 @@ -5164,6 +5164,9 @@ Library ------- +- Issue #7978: SocketServer doesn't handle syscall interruption; a wrapper was + added around SocketServer's use of select() to resolve that. + - In pdb, when Ctrl-C is entered while defining commands for a breakpoint, the old commands are restored.