diff --git a/Lib/test/test_minidom.py b/Lib/test/test_minidom.py --- a/Lib/test/test_minidom.py +++ b/Lib/test/test_minidom.py @@ -439,12 +439,26 @@ dom.unlink() self.confirm(domstr == str.replace("\n", "\r\n")) + def test_toprettyxml(self): + decl = '\n' + self.assertEqual(parseString('A').toprettyxml(), + decl + 'A\n') + self.assertEqual(parseString('AA').toprettyxml(), + decl + '\n\tA\n\tA\n\n') + self.assertEqual(parseString('AA').toprettyxml(), + decl + '\n\tA\n\tA\n\n') + self.assertEqual(parseString('AA').toprettyxml(), + decl + '\n\tA\n\tA\n\n') + self.assertEqual(parseString('AAA').toprettyxml(), + decl + '\n\tA\n\tA\n\tA\n\n') + def test_toprettyxml_preserves_content_of_text_node(self): - str = 'B' - dom = parseString(str) - dom2 = parseString(dom.toprettyxml()) - self.assertEqual(dom.childNodes[0].childNodes[0].toxml(), - dom2.childNodes[0].childNodes[0].toxml()) + for str in ('A', 'C'): + dom = parseString(str) + dom2 = parseString(dom.toprettyxml()) + self.assertEqual( + dom.getElementsByTagName('B')[0].childNodes[0].toxml(), + dom2.getElementsByTagName('B')[0].childNodes[0].toxml()) def testProcessingInstruction(self): dom = parseString('') diff --git a/Lib/xml/dom/minidom.py b/Lib/xml/dom/minidom.py --- a/Lib/xml/dom/minidom.py +++ b/Lib/xml/dom/minidom.py @@ -807,11 +807,15 @@ writer.write("\"") if self.childNodes: writer.write(">") - if self.childNodes[0].nodeType != Node.TEXT_NODE: + if (len(self.childNodes) == 1 and + self.childNodes[0].nodeType == Node.TEXT_NODE): + self.childNodes[0].writexml(writer, '', '', '') + else: writer.write(newl) - for node in self.childNodes: - node.writexml(writer,indent+addindent,addindent,newl) - writer.write("%s%s" % (indent,self.tagName,newl)) + for node in self.childNodes: + node.writexml(writer, indent+addindent, addindent, newl) + writer.write(indent) + writer.write("%s" % (self.tagName, newl)) else: writer.write("/>%s"%(newl)) @@ -1033,7 +1037,7 @@ return newText def writexml(self, writer, indent="", addindent="", newl=""): - _write_data(writer, self.data) + _write_data(writer, "%s%s%s" % (indent, self.data, newl)) # DOM Level 3 (WD 9 April 2002)