Index: Lib/netrc.py =================================================================== --- Lib/netrc.py (revision 86552) +++ Lib/netrc.py (working copy) @@ -34,11 +34,15 @@ def _parse(self, file, fp): lexer = shlex.shlex(fp) lexer.wordchars += r"""!"#$%&'()*+,-./:;<=>?@[\]^_`{|}~""" + lexer.commenters = lexer.commenters.replace('#', '') while 1: # Look for a machine, default, or macdef top-level keyword toplevel = tt = lexer.get_token() if not tt: break + elif tt[0] == '#': + fp.readline(); + continue; elif tt == 'machine': entryname = lexer.get_token() elif tt == 'default': Index: Lib/test/test_netrc.py =================================================================== --- Lib/test/test_netrc.py (revision 86552) +++ Lib/test/test_netrc.py (working copy) @@ -3,7 +3,13 @@ from test import support TEST_NETRC = """ + + #this is a comment +#this is a comment +# this is a comment + machine foo login log1 password pass1 account acct1 +machine bar login log1 password pass# account acct1 macdef macro1 line1 @@ -28,17 +34,20 @@ fp = open(temp_filename, mode) fp.write(TEST_NETRC) fp.close() + self.nrc = netrc.netrc(temp_filename) def tearDown(self): os.unlink(temp_filename) def test_case_1(self): - nrc = netrc.netrc(temp_filename) - self.assertTrue(nrc.macros == {'macro1':['line1\n', 'line2\n'], - 'macro2':['line3\n', 'line4\n']} - ) - self.assertTrue(nrc.hosts['foo'] == ('log1', 'acct1', 'pass1')) - self.assertTrue(nrc.hosts['default'] == ('log2', None, 'pass2')) + self.assertTrue(self.nrc.hosts['foo'] == ('log1', 'acct1', 'pass1')) + self.assertTrue(self.nrc.hosts['default'] == ('log2', None, 'pass2')) + + def test_macros(self): + self.assertTrue(self.nrc.macros == {'macro1':['line1\n', 'line2\n'], + 'macro2':['line3\n', 'line4\n']}) + def test_parses_passwords_with_hash_character(self): + self.assertTrue(self.nrc.hosts['bar'] == ('log1', 'acct1', 'pass#')) def test_main(): support.run_unittest(NetrcTestCase)