Index: Objects/floatobject.c =================================================================== --- Objects/floatobject.c (revision 64423) +++ Objects/floatobject.c (working copy) @@ -1204,8 +1204,58 @@ ">>> (-.25).as_integer_ratio()\n" "(-1, 4)"); +static PyObject * +_float_to_base(PyFloatObject *v, unaryfunc int_to_base) +{ + PyObject *mant, *conv, *result; + double x, fr; + int i, exp, n; + char *conv_str; + CONVERT_TO_DOUBLE(((PyObject *)v), x); + if (!Py_IS_FINITE(x)) + return PyObject_Repr((PyObject *)v); + fr = frexp(x, &exp); + for (i=0; i<300 && fr != floor(fr) ; i++) { + fr *= 2.0; + exp--; + } + mant = PyLong_FromDouble(floor(fr)); + if (mant == NULL) + return NULL; + conv = int_to_base(mant); + Py_DECREF(mant); + if (conv== NULL) + return NULL; + n = PyString_GET_SIZE(conv); + conv_str = PyString_AS_STRING(conv); + /* Remove the trailing 'L' if present */ + if (n && conv_str[n-1] == 'L') + conv_str[n-1] = '\0'; + result = PyString_FromFormat("%s * 2.0 ** %d", conv_str, exp); + Py_DECREF(conv); + return result; +} + static PyObject * +float_hex(PyFloatObject *v) +{ + return _float_to_base(v, PyLong_Type.tp_as_number->nb_hex); +} + +static PyObject * +float_oct(PyFloatObject *v) +{ + return _float_to_base(v, PyLong_Type.tp_as_number->nb_oct); +} + +static PyObject * +float_bin(PyFloatObject *v) +{ + return _float_to_base(v, PyLong_Type.tp_as_number->nb_bin); +} + +static PyObject * float_subtype_new(PyTypeObject *type, PyObject *args, PyObject *kwds); static PyObject * @@ -1490,8 +1540,8 @@ float_trunc, /*nb_int*/ float_trunc, /*nb_long*/ float_float, /*nb_float*/ - 0, /* nb_oct */ - 0, /* nb_hex */ + (unaryfunc)float_oct, /* nb_oct */ + (unaryfunc)float_hex, /* nb_hex */ 0, /* nb_inplace_add */ 0, /* nb_inplace_subtract */ 0, /* nb_inplace_multiply */ @@ -1507,6 +1557,8 @@ float_div, /* nb_true_divide */ 0, /* nb_inplace_floor_divide */ 0, /* nb_inplace_true_divide */ + 0, /* nb_index */ + (unaryfunc)float_bin, /* nb_bin */ }; PyTypeObject PyFloat_Type = { Index: Lib/test/test_builtin.py =================================================================== --- Lib/test/test_builtin.py (revision 64423) +++ Lib/test/test_builtin.py (working copy) @@ -631,6 +631,10 @@ self.assertEqual(hex(-16), '-0x10') self.assertEqual(hex(-16L), '-0x10L') self.assertRaises(TypeError, hex, {}) + self.assertEqual(hex(3.125), '0x19 * 2.0 ** -3') + for i in range(100): + x = random.expovariate(.05) + self.assertEqual(eval(hex(x)), x, (x, hex(x), eval(hex(x)))) def test_id(self): id(None) @@ -914,6 +918,10 @@ self.assertEqual(oct(-100), '-0144') self.assertEqual(oct(-100L), '-0144L') self.assertRaises(TypeError, oct, ()) + self.assertEqual(oct(3.125), '031 * 2.0 ** -3') + for i in range(100): + x = random.expovariate(.05) + self.assertEqual(eval(oct(x)), x) def write_testfile(self): # NB the first 4 lines are also used to test input and raw_input, below @@ -1466,6 +1474,10 @@ self.assertEqual(bin(2**65-1), '0b' + '1' * 65) self.assertEqual(bin(-(2**65)), '-0b1' + '0' * 65) self.assertEqual(bin(-(2**65-1)), '-0b' + '1' * 65) + self.assertEqual(bin(3.125), '0b11001 * 2.0 ** -3') + for i in range(100): + x = random.expovariate(.05) + self.assertEqual(eval(bin(x)), x) class TestSorted(unittest.TestCase):