Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(301)

#665194: datetime-RFC2822 roundtripping

Can't Edit
Can't Publish+Mail
Start Review
Created:
6 years, 7 months ago by walter
Modified:
4 years, 9 months ago
Reviewers:
belopolsky, merwok
CC:
tim.peters, barry, akuchling, doerwalter, belopols_me.com, ajaksu_gmail.com, eric.araujo, r.david.murray, sasha, devnull_psf.upfronthosting.co.za
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 8

Patch Set 3 #

Patch Set 4 #

Patch Set 5 #

Patch Set 6 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Lib/email/utils.py View 1 2 3 4 5 1 chunk +22 lines, -29 lines 0 comments Download
Lib/test/test_email/test_utils.py View 1 2 3 4 5 1 chunk +8 lines, -2 lines 0 comments Download

Messages

Total messages: 2
belopolsky_users.sourceforge.net
Posting partial review. I don't like the proposed API - will comment on the tracker. ...
6 years ago #1
eric.araujo
5 years, 10 months ago #2
http://bugs.python.org/review/665194/diff/2542/6111
File Lib/email/utils.py (right):

http://bugs.python.org/review/665194/diff/2542/6111#newcode119
Lib/email/utils.py:119: gmtime() and localtime(), otherwise the current time is
used.  timeval
> Please don't start sentence with a word that has to be in
> lowercase.  Use "Argument timeval' or rephrase.

I’ve also seen markup like “*timeval*” used in such contexts.

http://bugs.python.org/review/665194/diff/2542/6111#newcode154
Lib/email/utils.py:154: if time.daylight and now[-1]>0:
What about a couple spaces around the operator?
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld 894c83f36cb7