Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(39)

#6210: Exception Chaining missing method for suppressing context

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 4 months ago by PatrickWesterhoff
Modified:
1 year, 3 months ago
Reviewers:
benjamin, merwok, amauryfa
CC:
Georg, rhettinger, Nick Coghlan, AntoinePitrou, armin.ronacher_active-4.com, ezio.melotti, eric.araujo, mrabarnett, steve+python_pearwood.info, poke, stoneleaf, catalin.iacob, devnull_psf.upfronthosting.co.za, rhettinger, devnull_psf.upfronthosting.co.za, poke
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Patch Set 4 #

Patch Set 5 #

Patch Set 6 #

Patch Set 7 #

Total comments: 12

Patch Set 8 #

Patch Set 9 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/ACKS.txt View 1 chunk +1 line, -0 lines 0 comments Download
Doc/c-api/exceptions.rst View 5 6 7 8 1 chunk +13 lines, -6 lines 0 comments Download
Doc/library/exceptions.rst View 4 5 6 7 8 1 chunk +18 lines, -0 lines 0 comments Download
Doc/library/stdtypes.rst View 8 1 chunk +5 lines, -4 lines 0 comments Download
Doc/whatsnew/3.3.rst View 8 2 chunks +12 lines, -0 lines 0 comments Download
Include/pyerrors.h View 8 1 chunk +1 line, -0 lines 0 comments Download
Lib/test/test_exceptions.py View 3 4 5 6 7 8 1 chunk +23 lines, -6 lines 0 comments Download
Lib/test/test_raise.py View 1 2 3 4 5 6 7 8 4 chunks +81 lines, -1 line 0 comments Download
Lib/test/test_traceback.py View 8 1 chunk +15 lines, -0 lines 0 comments Download
Lib/traceback.py View 3 4 5 6 7 8 1 chunk +4 lines, -4 lines 0 comments Download
Misc/ACKS View 8 1 chunk +1 line, -0 lines 0 comments Download
Objects/exceptions.c View 3 4 5 6 7 8 2 chunks +19 lines, -12 lines 0 comments Download
Python/ceval.c View 1 2 3 4 5 6 7 8 1 chunk +10 lines, -9 lines 0 comments Download
Python/pythonrun.c View 2 3 4 5 6 7 8 1 chunk +5 lines, -1 line 0 comments Download

Messages

Total messages: 3
Benjamin Peterson
http://bugs.python.org/review/6210/diff/4108/14029 File Lib/test/test_raise.py (right): http://bugs.python.org/review/6210/diff/4108/14029#newcode87 Lib/test/test_raise.py:87: self.assertTrue(isinstance(e.__context__, TypeError)) assertIsInstance http://bugs.python.org/review/6210/diff/4108/14031 File Objects/exceptions.c (right): http://bugs.python.org/review/6210/diff/4108/14031#newcode309 Objects/exceptions.c:309: ...
1 year, 3 months ago #1
eric.araujo
A few comments on the docs. http://bugs.python.org/review/6210/diff/4108/14026 File Doc/c-api/exceptions.rst (right): http://bugs.python.org/review/6210/diff/4108/14026#newcode424 Doc/c-api/exceptions.rst:424: Return the cause ...
1 year, 3 months ago #2
amaury.forgeotdarc
1 year, 3 months ago #3
http://bugs.python.org/review/6210/diff/4108/14026
File Doc/c-api/exceptions.rst (right):

http://bugs.python.org/review/6210/diff/4108/14026#newcode425
Doc/c-api/exceptions.rst:425: set by ``raise ... from ...``) associated with the
exception as a new
Isn't "..." another spelling for Ellipsis?  This "raise ... from ..." becomes
confusing.
Maybe use something like "raise anException from anotherException"

http://bugs.python.org/review/6210/diff/4108/14030
File Lib/traceback.py (right):

http://bugs.python.org/review/6210/diff/4108/14030#newcode124
Lib/traceback.py:124: its.append(_iter_chain(cause, False, seen))
Why did you change None to False? this is the custom_tb parameter, which is
either a traceback or None.

http://bugs.python.org/review/6210/diff/4108/14031
File Objects/exceptions.c (right):

http://bugs.python.org/review/6210/diff/4108/14031#newcode309
Objects/exceptions.c:309: ;
Agreed. A Py_INCREF(Py_None) looks more correct here.

http://bugs.python.org/review/6210/diff/4108/14032
File Python/ceval.c (right):

http://bugs.python.org/review/6210/diff/4108/14032#newcode3587
Python/ceval.c:3587: equivalent to 'raise ...' */
Since ... is Ellipsis, this comment is confusing. 
maybe 'raise exc from Ellipsis' and 'raise exc'
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld cbc36f91f3f7