Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(94)

#3754: cross-compilation support for python build

Can't Edit
Can't Publish+Mail
Start Review
Created:
2 years, 1 month ago by bugtrack
Modified:
11 months, 3 weeks ago
Reviewers:
amauryfa
CC:
doko, wrobell_pld-linux.org, vapier_users.sourceforge.net, tarek_ziade.org, eric.araujo, rpetrov, Arfrever.FTA_GMail.Com, devurandom_gmx.net, WhiteTiger, BreamoreBoy, devnull_psf.upfronthosting.co.za, ipsuid_gmail.com, greg.hellings_gmail.com, kalevlember_gmail.com, david_marqvar.dk, mingw.android_gmail.com, eudoxos, ambrop7_gmail.com
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 8

Patch Set 3 #

Patch Set 4 #

Patch Set 5 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Include/py_curses.h View 1 2 3 4 2 chunks +5 lines, -0 lines 0 comments Download
Lib/distutils/README View 1 2 3 4 1 chunk +11 lines, -0 lines 0 comments Download
Lib/packaging/tests/support.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
Lib/sysconfig.py View 1 2 3 4 7 chunks +19 lines, -35 lines 0 comments Download
Lib/test/regrtest.py View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
Lib/test/test_capi.py View 1 2 3 4 1 chunk +5 lines, -3 lines 0 comments Download
Lib/test/test_httpservers.py View 1 2 3 4 3 chunks +20 lines, -12 lines 0 comments Download
Lib/test/test_platform.py View 1 2 3 4 2 chunks +7 lines, -0 lines 0 comments Download
Lib/test/test_sysconfig.py View 1 2 3 4 4 chunks +15 lines, -8 lines 0 comments Download
Lib/test/test_tools.py View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
Makefile.pre.in View 1 2 3 4 12 chunks +61 lines, -46 lines 0 comments Download
configure.ac View 1 2 3 4 17 chunks +176 lines, -60 lines 0 comments Download
pyconfig.h.in View 1 2 3 4 2 chunks +8 lines, -2 lines 0 comments Download
setup.py View 1 2 3 4 49 chunks +133 lines, -75 lines 0 comments Download
setup_info.in View 1 2 3 4 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 1
amaury.forgeotdarc
2 years ago #1
http://bugs.python.org/review/3754/diff/2638/6391
File Lib/sysconfig.py (right):

http://bugs.python.org/review/3754/diff/2638/6391#newcode9
Lib/sysconfig.py:9: # => so lets use abspath again ;)
I suppose realpath can be useful sometimes, when there are links for example.
Did you consider using realpath() first, then fall back to abspath()?

http://bugs.python.org/review/3754/diff/2638/6392
File Lib/test/test_capi.py (right):

http://bugs.python.org/review/3754/diff/2638/6392#newcode158
Lib/test/test_capi.py:158: exe = find_executable("_testembed", basepath)
What is the issue here? Are these tests run in a cross-plaform manner?

http://bugs.python.org/review/3754/diff/2638/6393
File Lib/test/test_httpservers.py (right):

http://bugs.python.org/review/3754/diff/2638/6393#newcode321
Lib/test/test_httpservers.py:321: #NOTE: issue 7668 is bogus
what is "bogus"? the issue, the tests, or the current implementation of cross
compilation?
Again, why is it difficult to spawn another python interpreter?

http://bugs.python.org/review/3754/diff/2638/6397
File configure.in (right):

http://bugs.python.org/review/3754/diff/2638/6397#newcode769
configure.in:769: AC_COMPILE_IFELSE([AC_LANG_SOURCE([[]])],
The previous code contained a main() function, I wonder if it is necessary

http://bugs.python.org/review/3754/diff/2638/6397#newcode1586
configure.in:1586: dnl if test "$have_pthread_t" = yes ; then
Remove this part, then

http://bugs.python.org/review/3754/diff/2638/6397#newcode3020
configure.in:3020: if test $have_getaddrinfo = no || test
"$ac_cv_buggy_getaddrinfo" = yes
Is this related to the feature?

http://bugs.python.org/review/3754/diff/2638/6399
File setup.py (right):

http://bugs.python.org/review/3754/diff/2638/6399#newcode605
setup.py:605: do_readline = re.search(r"#s*define\s+HAVE_LIBREADLINE\s+1\s*",
pyconfig_h_data)
Please limit to 80 columns

http://bugs.python.org/review/3754/diff/2638/6399#newcode1644
setup.py:1644: if not cross_compiling and 'd' not in sys.abiflags:
Is it a limitation of cross compilation, or something normal?
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld cbc36f91f3f7