Issue 3665: Support \u and \U escapes in regexes

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

#3665: Support \u and \U escapes in regexes

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 months, 4 weeks ago by georg

Modified:
11 months, 1 week ago

Reviewers:
storchaka

CC:
Georg, ishimoto, AntoinePitrou, timehorse_users.sourceforge.net, ezio.melotti, eric.araujo, mrabarnett, devnull_psf.upfronthosting.co.za, storchaka

Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 5

Patch Set 3 #

Patch Set 4 #

Created: 11 months, 1 week ago

Download raw patch set

Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
Doc/library/re.rst	View	1 2 3	2 chunks	+5 lines, -2 lines	0 comments	Download
Lib/sre_parse.py	View	1 2 3	5 chunks	+49 lines, -17 lines	0 comments	Download
Lib/test/test_re.py	View	1 2 3	1 chunk	+83 lines, -15 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

storchaka

11 months, 2 weeks ago #1

http://bugs.python.org/review/3665/diff/5054/Lib/sre_parse.py
File Lib/sre_parse.py (right):

http://bugs.python.org/review/3665/diff/5054/Lib/sre_parse.py#newcode264
Lib/sre_parse.py:264: if c > sys.maxunicode:
Since 3.3 sys.maxunicode is always 0x10FFFF.

http://bugs.python.org/review/3665/diff/5054/Lib/sre_parse.py#newcode497
Lib/sre_parse.py:497: if lo > sys.maxunicode or hi > sys.maxunicode:
It will never happen. Checking is done in _class_escape.

http://bugs.python.org/review/3665/diff/5054/Lib/sre_parse.py#newcode702
Lib/sre_parse.py:702: if code[0] == LITERAL and code[1] > sys.maxunicode:
It will never happen. Checking is done in _escape.

http://bugs.python.org/review/3665/diff/5054/Lib/test/test_re.py
File Lib/test/test_re.py (right):

http://bugs.python.org/review/3665/diff/5054/Lib/test/test_re.py#newcode536
Lib/test/test_re.py:536: self.assertNotEqual(re.match(r"\u1234", "\u1234"),
None)
assertIsNotNone

http://bugs.python.org/review/3665/diff/5054/Lib/test/test_re.py#newcode554
Lib/test/test_re.py:554: if sys.maxunicode <= 0xffff:
Since 3.3 sys.maxunicode is always 0x10FFFF.

Expand All Messages | Collapse All Messages