Lib/http/server.py - Issue 2830: Copy cgi.escape() to html

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Unified Diff: Lib/http/server.py

Issue 2830: Copy cgi.escape() to html

Patch Set: Created 2 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

Index: Lib/http/server.py

===================================================================

--- Lib/http/server.py (revision 84355)

+++ Lib/http/server.py (working copy)

@@ -84,7 +84,7 @@

__all__ = ["HTTPServer", "BaseHTTPRequestHandler"]

-import cgi

+import html

import email.message

import email.parser

import http.client

@@ -677,7 +677,7 @@

return None

list.sort(key=lambda a: a.lower())

r = []

- displaypath = cgi.escape(urllib.parse.unquote(self.path))

+ displaypath = html.escape(urllib.parse.unquote(self.path))

r.append('<!DOCTYPE html PUBLIC "-//W3C//DTD HTML 3.2 Final//EN">')

r.append("<html>\n<title>Directory listing for %s</title>\n" % displaypath)

r.append("<body>\n<h2>Directory listing for %s</h2>\n" % displaypath)

@@ -693,7 +693,7 @@

displayname = name + "@"

# Note: a link to a directory displays with @ and links with /

r.append('<li><a href="%s">%s</a>\n'

- % (urllib.parse.quote(linkname), cgi.escape(displayname)))

+ % (urllib.parse.quote(linkname), html.escape(displayname)))

r.append("</ul>\n<hr>\n</body>\n</html>\n")

enc = sys.getfilesystemencoding()

encoded = ''.join(r).encode(enc)

« no previous file with comments | « Lib/html/__init__.py ('k') | Lib/lib2to3/tests/test_util.py » ('j') | no next file with comments »