Issue 15625: Support u and w codes in memoryview

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

#15625: Support u and w codes in memoryview

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 months, 1 week ago by martin

Modified:
10 months, 1 week ago

Reviewers:
stefan-usenet

CC:
loewis, oliphant_enthought.com, Ronald Oussoren, Nick Coghlan, Arfrever.FTA_GMail.Com, skrah

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 10 months, 1 week ago

Download raw patch set

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
		Lib/test/test_memoryview.py	View		1 chunk	+13 lines, -0 lines	0 comments	Download
		Objects/memoryobject.c	View		7 chunks	+32 lines, -0 lines	1 comment	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

Apart from a small return value typo, the patch looks good. But I think we
should sort out whether the array.array semantics are desirable in the first
place.

http://bugs.python.org/review/15625/diff/5720/Objects/memoryobject.c
File Objects/memoryobject.c (right):

http://bugs.python.org/review/15625/diff/5720/Objects/memoryobject.c#newcode1820
Objects/memoryobject.c:1820: return NULL;
This should return -1.

Expand All Messages | Collapse All Messages