Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(4079)

#15502: Meta path finders and path entry finders are different, but share an ABC

Can't Edit
Can't Publish+Mail
Start Review
Created:
9 months, 2 weeks ago by ncoghlan
Modified:
9 months, 1 week ago
Reviewers:
brett
CC:
barry, brett.cannon, Georg, PJ Eby, Nick Coghlan, eric.smith, Arfrever.FTA_GMail.Com, devnull_psf.upfronthosting.co.za, eric.snow
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Patch Set 4 #

Patch Set 5 #

Patch Set 6 #

Patch Set 7 #

Patch Set 8 #

Patch Set 9 #

Patch Set 10 #

Patch Set 11 #

Total comments: 8
Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/importlib.rst View 1 2 3 4 5 6 7 8 9 10 3 chunks +21 lines, -13 lines 2 comments Download
Lib/importlib/__init__.py View 1 2 3 4 5 6 7 8 9 10 1 chunk +3 lines, -3 lines 0 comments Download
Lib/importlib/_bootstrap.py View 1 2 3 4 5 6 7 8 9 10 1 chunk +8 lines, -0 lines 0 comments Download
Lib/importlib/abc.py View 1 2 3 4 5 6 7 8 9 10 1 chunk +23 lines, -15 lines 6 comments Download
Lib/test/test_importlib/test_api.py View 1 2 3 4 5 6 7 8 9 10 1 chunk +7 lines, -3 lines 0 comments Download
Python/importlib.h View 1 2 3 4 5 6 7 8 9 10 5 chunks +1191 lines, -1159 lines 0 comments Download

Messages

Total messages: 2
Nick Coghlan
Finder should be registered with both of the new metaclasses, since Finder subclasses should be ...
9 months, 1 week ago #1
brett.cannon
9 months, 1 week ago #2
Will show up in the commit I'm about to make.

http://bugs.python.org/review/15502/diff/5644/Doc/library/importlib.rst
File Doc/library/importlib.rst (right):

http://bugs.python.org/review/15502/diff/5644/Doc/library/importlib.rst#newco...
Doc/library/importlib.rst:164: is meant for use only within the path-oriented
import subsystem provided
On 2012/08/10 17:22:42, Nick Coghlan wrote:
> path-based (for consistency with above wording and "path-based" is a simpler
> phrase)

Done.

http://bugs.python.org/review/15502/diff/5644/Lib/importlib/abc.py
File Lib/importlib/abc.py (left):

http://bugs.python.org/review/15502/diff/5644/Lib/importlib/abc.py#oldcode62
Lib/importlib/abc.py:62: machinery.PathFinder, machinery.WindowsRegistryFinder)
On 2012/08/10 17:22:42, Nick Coghlan wrote:
> register Finder as well

Done by directly subclassing from Finder.

http://bugs.python.org/review/15502/diff/5644/Lib/importlib/abc.py#oldcode78
Lib/importlib/abc.py:78: _register(PathEntryFinder, machinery.FileFinder)
On 2012/08/10 17:22:42, Nick Coghlan wrote:
> register Finder

Done by subclassing.

http://bugs.python.org/review/15502/diff/5644/Lib/importlib/abc.py
File Lib/importlib/abc.py (right):

http://bugs.python.org/review/15502/diff/5644/Lib/importlib/abc.py#newcode30
Lib/importlib/abc.py:30: It may subclassed for compatibility with legacy third
party
On 2012/08/10 17:22:42, Nick Coghlan wrote:
> "may be subclassed"

Done.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld cbc36f91f3f7