Issue 15469: Correct __sizeof__ support for deque

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

#15469: Correct sizeof support for deque

Can't Edit
Can't Publish+Mail
Start Review

Created:
9 months, 4 weeks ago by storchaka

Modified:
9 months, 3 weeks ago

Reviewers:
martin

CC:
rhettinger, meadori, devnull_psf.upfronthosting.co.za, storchaka

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Patch Set 2 #

Patch Set 3 #

Patch Set 4 #

Patch Set 5 #

Patch Set 6 #

Created: 9 months, 3 weeks ago

Download raw patch set

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
		Lib/test/test_deque.py	View	1 2 3 4 5	2 chunks	+16 lines, -0 lines	0 comments	Download
		Modules/_collectionsmodule.c	View	1 2 3 4 5	2 chunks	+20 lines, -1 line	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

loewis

9 months, 3 weeks ago #1

http://bugs.python.org/review/15469/diff/5535/Modules/_collectionsmodule.c
File Modules/_collectionsmodule.c (right):

http://bugs.python.org/review/15469/diff/5535/Modules/_collectionsmodule.c#ne...
Modules/_collectionsmodule.c:942: for (b = deque->leftblock; b != NULL; b =
b->rightlink) {
I think you can compute the number of blocks by rounding up deque->len/BLOCKLEN;
no need to iterate over the deque.