Issue 15176: Clarify the behavior of listdir(fd) in both code and documentation

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

#15176: Clarify the behavior of listdir(fd) in both code and documentation

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 months ago by larry

Modified:
11 months ago

Reviewers:
georg

CC:
Georg, Nick Coghlan, larry, Arfrever.FTA_GMail.Com, devnull_psf.upfronthosting.co.za

Visibility:
Public.

Patch Set 2 #

Created: 11 months ago

Download raw patch set

Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
Doc/library/os.rst	View	1	1 chunk	+9 lines, -6 lines	0 comments	Download
Lib/test/test_posix.py	View	1	1 chunk	+12 lines, -7 lines	0 comments	Download
Modules/posixmodule.c	View	1	6 chunks	+22 lines, -13 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Georg

http://bugs.python.org/review/15176/diff/5232/Lib/test/test_posix.py File Lib/test/test_posix.py (right): http://bugs.python.org/review/15176/diff/5232/Lib/test/test_posix.py#newcode450 Lib/test/test_posix.py:450: requires_listdir = unittest.skipUnless(hasattr(posix, 'listdir'), Hmm, do we have *any* ...

11 months ago #1

larry

11 months ago #2

http://bugs.python.org/review/15176/diff/5232/Lib/test/test_posix.py
File Lib/test/test_posix.py (right):

http://bugs.python.org/review/15176/diff/5232/Lib/test/test_posix.py#newcode450
Lib/test/test_posix.py:450: requires_listdir =
unittest.skipUnless(hasattr(posix, 'listdir'),
On 2012/06/25 10:40:41, Georg wrote:
> Hmm, do we have *any* supported platform without listdir()?

You can see, the previous code was littered with if hasattr(posix, 'listdir')
checks; I just cleaned 'em up.  But you're right, posix_listdir is
unconditional.  I'll remove those checks.

Expand All Messages | Collapse All Messages

#15176: Clarify the behavior of listdir(fd) in both code and documentation

Patch Set 1 #

Patch Set 2 #

Messages