http://bugs.python.org/review/15164/diff/5228/Lib/platform.py File Lib/platform.py (right): http://bugs.python.org/review/15164/diff/5228/Lib/platform.py#newcode1032 Lib/platform.py:1032: "system node release version machine processor") Why not use the same names for the items also in os.uname() ? Ah, I see, because of the accessors below... hm. http://bugs.python.org/review/15164/diff/5228/Lib/platform.py#newcode1168 Lib/platform.py:1168: _uname_cache = uname_result(system,node,release,version,machine,processor) While you're at it, you could introduce PEP 8 conform spacing :) http://bugs.python.org/review/15164/diff/5228/Lib/test/test_platform.py File Lib/test/test_platform.py (right): http://bugs.python.org/review/15164/diff/5228/Lib/test/test_platform.py#newcode8 Lib/test/test_platform.py:8: from test import support Could add a test checking for the attributes somewhere in here.
http://bugs.python.org/review/15164/diff/5229/Doc/library/platform.rst File Doc/library/platform.rst (right): http://bugs.python.org/review/15164/diff/5229/Doc/library/platform.rst#newcod... Doc/library/platform.rst:161: Fairly portable uname interface. Returns a :func:`collections.namedtuple` I would put a ~ in here (`~collections.namedtuple`). http://bugs.python.org/review/15164/diff/5229/Doc/library/platform.rst#newcod... Doc/library/platform.rst:166: in the :func:`os.uname` result. Should also note that the attribute names are different.
Done and done. http://bugs.python.org/review/15164/diff/5229/Doc/library/platform.rst File Doc/library/platform.rst (right): http://bugs.python.org/review/15164/diff/5229/Doc/library/platform.rst#newcod... Doc/library/platform.rst:161: Fairly portable uname interface. Returns a :func:`collections.namedtuple` On 2012/06/24 23:20:19, Georg wrote: > I would put a ~ in here (`~collections.namedtuple`). Done. http://bugs.python.org/review/15164/diff/5229/Doc/library/platform.rst#newcod... Doc/library/platform.rst:166: in the :func:`os.uname` result. On 2012/06/24 23:20:19, Georg wrote: > Should also note that the attribute names are different. Done.