Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3149)

#15164: add platform.uname() namedtuple interface?

Can't Edit
Can't Publish+Mail
Start Review
Created:
11 months ago by georg
Modified:
11 months ago
Reviewers:
larry
CC:
Georg, larry, devnull_psf.upfronthosting.co.za
Visibility:
Public.

Patch Set 1 #

Total comments: 3

Patch Set 2 #

Total comments: 4

Patch Set 3 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/platform.rst View 1 2 1 chunk +10 lines, -4 lines 0 comments Download
Lib/platform.py View 1 2 9 chunks +11 lines, -7 lines 0 comments Download
Lib/sysconfig.py View 1 2 1 chunk +1 line, -1 line 0 comments Download
Lib/test/test__locale.py View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
Lib/test/test_platform.py View 1 2 2 chunks +7 lines, -1 line 0 comments Download

Messages

Total messages: 3
Georg
http://bugs.python.org/review/15164/diff/5228/Lib/platform.py File Lib/platform.py (right): http://bugs.python.org/review/15164/diff/5228/Lib/platform.py#newcode1032 Lib/platform.py:1032: "system node release version machine processor") Why not use ...
11 months ago #1
Georg
http://bugs.python.org/review/15164/diff/5229/Doc/library/platform.rst File Doc/library/platform.rst (right): http://bugs.python.org/review/15164/diff/5229/Doc/library/platform.rst#newcode161 Doc/library/platform.rst:161: Fairly portable uname interface. Returns a :func:`collections.namedtuple` I would ...
11 months ago #2
larry
11 months ago #3
Done and done.

http://bugs.python.org/review/15164/diff/5229/Doc/library/platform.rst
File Doc/library/platform.rst (right):

http://bugs.python.org/review/15164/diff/5229/Doc/library/platform.rst#newcod...
Doc/library/platform.rst:161: Fairly portable uname interface. Returns a
:func:`collections.namedtuple`
On 2012/06/24 23:20:19, Georg wrote:
> I would put a ~ in here (`~collections.namedtuple`).

Done.

http://bugs.python.org/review/15164/diff/5229/Doc/library/platform.rst#newcod...
Doc/library/platform.rst:166: in the :func:`os.uname` result.
On 2012/06/24 23:20:19, Georg wrote:
> Should also note that the attribute names are different.

Done.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld cbc36f91f3f7