Issue 15096: Drop support for the "ur" string prefix

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

#15096: Drop support for the "ur" string prefix

Can't Edit
Can't Publish+Mail
Start Review

Created:
11 months, 1 week ago by ncoghlan

Modified:
11 months ago

Reviewers:
storchaka

CC:
Georg, Vinay Sajip, Nick Coghlan, christian.heimes, armin.ronacher_active-4.com, ezio.melotti, Arfrever.FTA_GMail.Com, flox, devnull_psf.upfronthosting.co.za, storchaka

Visibility:
Public.

Patch Set 2 #

Total comments: 2

Created: 11 months ago

Download raw patch set

Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
Doc/reference/lexical_analysis.rst	View	1	2 chunks	+4 lines, -2 lines	1 comment	Download
Lib/test/test_strlit.py	View	1	1 chunk	+9 lines, -0 lines	0 comments	Download
Lib/test/test_tokenize.py	View	1	3 chunks	+13 lines, -15 lines	1 comment	Download
Lib/tokenize.py	View	1	4 chunks	+3 lines, -9 lines	0 comments	Download
Misc/NEWS	View	1	1 chunk	+3 lines, -0 lines	0 comments	Download
Parser/tokenizer.c	View	1	2 chunks	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

storchaka

http://bugs.python.org/review/15096/diff/5155/Lib/test/test_strlit.py File Lib/test/test_strlit.py (right): http://bugs.python.org/review/15096/diff/5155/Lib/test/test_strlit.py#newcode131 Lib/test/test_strlit.py:131: self.assertRaises(SyntaxError, eval, """ ru'' """) Are ub'' and bu'' ...

11 months, 1 week ago #1

storchaka

11 months ago #2

All other is look good for me.

http://bugs.python.org/review/15096/diff/5163/Doc/reference/lexical_analysis.rst
File Doc/reference/lexical_analysis.rst (right):

http://bugs.python.org/review/15096/diff/5163/Doc/reference/lexical_analysis....
Doc/reference/lexical_analysis.rst:459: Support for the unicode legacy literal
(``u'value'``) and other
"other versions" is not true now.

http://bugs.python.org/review/15096/diff/5163/Lib/test/test_tokenize.py
File Lib/test/test_tokenize.py (right):

http://bugs.python.org/review/15096/diff/5163/Lib/test/test_tokenize.py#newco...
Lib/test/test_tokenize.py:303: # NOTE: ur"" syntax isn't supported. This checks
that tokenize
May be just to drop this doctest? I don't see any other test which tests illegal
sequences.

Expand All Messages | Collapse All Messages

#15096: Drop support for the "ur" string prefix

Patch Set 1 #

Patch Set 2 #

Messages