Issue 14736: Add {encode,decode}_filter_properties() functions to lzma module

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

#14736: Add {encode,decode}_filter_properties() functions to lzma module

Can't Edit
Can't Publish+Mail
Start Review

Created:
1 year ago by nadeem.vawda

Modified:
1 year ago

Reviewers:
martin

CC:
AntoinePitrou, nadeem.vawda, storchaka

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 #

Created: 1 year ago

Download raw patch set

Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
Doc/library/lzma.rst	View		1 chunk	+26 lines, -0 lines	0 comments	Download
Lib/lzma.py	View		1 chunk	+1 line, -0 lines	0 comments	Download
Lib/test/test_lzma.py	View		1 chunk	+43 lines, -0 lines	0 comments	Download
Modules/_lzmamodule.c	View	1	5 chunks	+182 lines, -4 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

loewis

The patch looks fine to me, except for the comment issue below. http://bugs.python.org/review/14736/diff/4831/17094 File Modules/_lzmamodule.c ...

1 year ago #1

nadeem.vawda

1 year ago #2

http://bugs.python.org/review/14736/diff/4831/17094
File Modules/_lzmamodule.c (right):

http://bugs.python.org/review/14736/diff/4831/17094#newcode1169
Modules/_lzmamodule.c:1169: /* XXX We use vanilla free() here instead of
PyMem_Free(), since
On 2012/05/06 09:34:21, loewis wrote:
> Why is this an XXX comment? The API usage looks correct to me.

You're right, it's not necessary. Fixed.

> You could setup an LZMA allocator if you wanted to.

True, but it seems like a lot of added code for a cosmetic
matter - we'd have to define wrappers for PyMem_Malloc() and
PyMem_Free(), since the allocator API expects different
function signatures.

Expand All Messages | Collapse All Messages