Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(3247)

#14705: Add 'bool' format character to PyArg_ParseTuple*

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 1 month ago by larry
Modified:
1 year, 1 month ago
Reviewers:
storchaka
CC:
loewis, Georg, rhettinger, mark.dickinson, larry, eric.smith, Benjamin Peterson, devnull_psf.upfronthosting.co.za, storchaka
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 2

Patch Set 3 #

Patch Set 4 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/c-api/arg.rst View 1 chunk +9 lines, -0 lines 0 comments Download
Lib/test/test_getargs2.py View 1 2 3 2 chunks +31 lines, -0 lines 0 comments Download
Modules/_testcapimodule.c View 1 2 3 2 chunks +10 lines, -0 lines 0 comments Download
Python/getargs.c View 1 2 3 1 chunk +12 lines, -0 lines 0 comments Download

Messages

Total messages: 3
storchaka
Patch looks good to me.
1 year, 1 month ago #1
storchaka
http://bugs.python.org/review/14705/diff/4816/17033 File Python/getargs.c (right): http://bugs.python.org/review/14705/diff/4816/17033#newcode822 Python/getargs.c:822: return converterr("cannot convert arg to boolean", I am not ...
1 year, 1 month ago #2
larry
1 year, 1 month ago #3
http://bugs.python.org/review/14705/diff/4816/17033
File Python/getargs.c (right):

http://bugs.python.org/review/14705/diff/4816/17033#newcode822
Python/getargs.c:822: return converterr("cannot convert arg to boolean",
On 2012/05/04 19:57:16, storchaka wrote:
> I am not shure we should not reraise the original exception.

My mistake.  Done.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld cbc36f91f3f7