Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(473)

#14369: make __closure__ writable

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 2 months ago by yselivanov
Modified:
1 year ago
Reviewers:
andrew.svetlov, benjamin
CC:
Nick Coghlan, AntoinePitrou, Benjamin Peterson, asvetlov, meadori, Yury.Selivanov, sbt, eric.snow
Visibility:
Public.

Patch Set 1 #

Total comments: 7

Patch Set 2 #

Patch Set 3 #

Patch Set 4 #

Total comments: 1

Patch Set 5 #

Patch Set 6 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/reference/datamodel.rst View 1 chunk +1 line, -1 line 0 comments Download
Lib/test/test_funcattrs.py View 1 2 3 4 5 1 chunk +48 lines, -3 lines 0 comments Download
Objects/funcobject.c View 1 2 3 4 5 3 chunks +55 lines, -2 lines 0 comments Download

Messages

Total messages: 5
asvetlov
http://bugs.python.org/review/14369/diff/4471/15943 File Lib/test/test_funcattrs.py (right): http://bugs.python.org/review/14369/diff/4471/15943#newcode72 Lib/test/test_funcattrs.py:72: def test___globals__ure__(self): Bad name http://bugs.python.org/review/14369/diff/4471/15943#newcode83 Lib/test/test_funcattrs.py:83: self.assertEqual(f(), 42) Need ...
1 year, 2 months ago #1
Yury.Selivanov
http://bugs.python.org/review/14369/diff/4471/15944 File Objects/funcobject.c (right): http://bugs.python.org/review/14369/diff/4471/15944#newcode388 Objects/funcobject.c:388: "__closure__ must be set to a tuple object"); Well, ...
1 year, 2 months ago #2
Yury.Selivanov
http://bugs.python.org/review/14369/diff/4471/15943 File Lib/test/test_funcattrs.py (right): http://bugs.python.org/review/14369/diff/4471/15943#newcode72 Lib/test/test_funcattrs.py:72: def test___globals__ure__(self): Yeah, my bad. Fixed. It seems that ...
1 year, 2 months ago #3
asvetlov
http://bugs.python.org/review/14369/diff/4471/15944 File Objects/funcobject.c (right): http://bugs.python.org/review/14369/diff/4471/15944#newcode388 Objects/funcobject.c:388: "__closure__ must be set to a tuple object"); Good ...
1 year, 2 months ago #4
Benjamin Peterson
1 year, 2 months ago #5
http://bugs.python.org/review/14369/diff/4486/15987
File Objects/funcobject.c (right):

http://bugs.python.org/review/14369/diff/4486/15987#newcode371
Objects/funcobject.c:371: Py_INCREF(Py_None);
Py_RETURN_NONE
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld cbc36f91f3f7