make __closure__ writable

[asvetlov]

http://bugs.python.org/review/14369/diff/4471/15943
File Lib/test/test_funcattrs.py (right):

http://bugs.python.org/review/14369/diff/4471/15943#newcode72
Lib/test/test_funcattrs.py:72: def test___globals__ure__(self):
Bad name

http://bugs.python.org/review/14369/diff/4471/15943#newcode83
Lib/test/test_funcattrs.py:83: self.assertEqual(f(), 42)
Need for check on exception if assign non-tuple

http://bugs.python.org/review/14369/diff/4471/15944
File Objects/funcobject.c (right):

http://bugs.python.org/review/14369/diff/4471/15944#newcode388
Objects/funcobject.c:388: "__closure__ must be set to a tuple object");
While raising TypeError instead of SystemError thrown from PyFunction_SetClosure
is ok I prefer to see exception message like "__closure__ must be set to a tuple
object, got list".

[Yury.Selivanov]

http://bugs.python.org/review/14369/diff/4471/15944
File Objects/funcobject.c (right):

http://bugs.python.org/review/14369/diff/4471/15944#newcode388
Objects/funcobject.c:388: "__closure__ must be set to a tuple object");
Well, I use the same exception and format as for 'set_globals'. If we want to
change it here, we need to update error messages across file, which I think is a
different issue.

On 2012/03/19 20:32:28, asvetlov wrote:
> While raising TypeError instead of SystemError thrown from
PyFunction_SetClosure
> is ok I prefer to see exception message like "__closure__ must be set to a
tuple
> object, got list".

[Yury.Selivanov]

http://bugs.python.org/review/14369/diff/4471/15943
File Lib/test/test_funcattrs.py (right):

http://bugs.python.org/review/14369/diff/4471/15943#newcode72
Lib/test/test_funcattrs.py:72: def test___globals__ure__(self):
Yeah, my bad.  Fixed.  It seems that I've uploaded the fixed patch at the very
same time you've published your review.

On 2012/03/19 20:32:28, asvetlov wrote:
> Bad name

http://bugs.python.org/review/14369/diff/4471/15943#newcode83
Lib/test/test_funcattrs.py:83: self.assertEqual(f(), 42)
Valid point.

On 2012/03/19 20:32:28, asvetlov wrote:
> Need for check on exception if assign non-tuple

[asvetlov]

http://bugs.python.org/review/14369/diff/4471/15944
File Objects/funcobject.c (right):

http://bugs.python.org/review/14369/diff/4471/15944#newcode388
Objects/funcobject.c:388: "__closure__ must be set to a tuple object");
Good point. Let's follow `set_globals` semantic.

[Benjamin Peterson]

http://bugs.python.org/review/14369/diff/4486/15987
File Objects/funcobject.c (right):

http://bugs.python.org/review/14369/diff/4486/15987#newcode371
Objects/funcobject.c:371: Py_INCREF(Py_None);
Py_RETURN_NONE