Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(1313)

#14310: Socket duplication for windows

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 2 months ago by kristjan
Modified:
1 year, 1 month ago
Reviewers:
shibturn, jimjjewett
CC:
AntoinePitrou, krisvale, giampaolo.rodola, santa4nt, devnull_psf.upfronthosting.co.za, sbt
Visibility:
Public.

Patch Set 1 #

Total comments: 10

Patch Set 2 #

Patch Set 3 #

Total comments: 6

Patch Set 4 #

Patch Set 5 #

Patch Set 6 #

Patch Set 7 #

Patch Set 8 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
Doc/library/socket.rst View 2 chunks +25 lines, -0 lines 0 comments Download
Lib/socket.py View 3 4 5 6 7 3 chunks +9 lines, -1 line 0 comments Download
Lib/test/test_socket.py View 1 2 3 4 5 6 3 chunks +105 lines, -0 lines 0 comments Download
Modules/socketmodule.c View 1 2 3 4 5 6 7 3 chunks +66 lines, -7 lines 0 comments Download

Messages

Total messages: 5
sbt
http://bugs.python.org/review/14310/diff/4411/15802 File Modules/socketmodule.c (right): http://bugs.python.org/review/14310/diff/4411/15802#newcode3783 Modules/socketmodule.c:3783: if (!PyArg_ParseTuple(arg, "i", &processId)) Shouldn't "i" be "I" since ...
1 year, 2 months ago #1
Jim.Jewett
http://bugs.python.org/review/14310/diff/4411/15802 File Modules/socketmodule.c (right): http://bugs.python.org/review/14310/diff/4411/15802#newcode3835 Modules/socketmodule.c:3835: sock_duplicate_doc}, Aren't new methods usually added to the end, ...
1 year, 2 months ago #2
krisvale
Thanks, I'll submit an updated version soon. http://bugs.python.org/review/14310/diff/4411/15802 File Modules/socketmodule.c (right): http://bugs.python.org/review/14310/diff/4411/15802#newcode3783 Modules/socketmodule.c:3783: if (!PyArg_ParseTuple(arg, ...
1 year, 2 months ago #3
sbt
http://bugs.python.org/review/14310/diff/4472/15947 File Modules/socketmodule.c (right): http://bugs.python.org/review/14310/diff/4472/15947#newcode3794 Modules/socketmodule.c:3794: "duplicate(process_id) -> bytes\n\ Should be "fromshare(process_id) -> bytes" http://bugs.python.org/review/14310/diff/4472/15947#newcode3799 ...
1 year, 2 months ago #4
krisvale
1 year, 2 months ago #5
http://bugs.python.org/review/14310/diff/4472/15947
File Modules/socketmodule.c (right):

http://bugs.python.org/review/14310/diff/4472/15947#newcode3794
Modules/socketmodule.c:3794: "duplicate(process_id) -> bytes\n\
On 2012/03/19 19:55:20, sbt wrote:
> Should be "fromshare(process_id) -> bytes"

Done.

http://bugs.python.org/review/14310/diff/4472/15947#newcode3799
Modules/socketmodule.c:3799: socket.fromshared().");
On 2012/03/19 19:55:20, sbt wrote:
> Should be "socket.fromshare()"

Done.

http://bugs.python.org/review/14310/diff/4472/15947#newcode3965
Modules/socketmodule.c:3965: /* recreate a socket that was duplicated */
On 2012/03/19 19:55:21, sbt wrote:
> You still seem to be using 4th argument of socket constructor instead of
> implementing socket.fromshare().
see socket.py.  socket.fromshare() is implemented in the same way as
socket.fromfd(), by invoking the socket.socket() constructor with the
undocumented fourth argument.
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld cbc36f91f3f7