Objects/bytearrayobject.c - Issue 14203: bytearray_getbuffer: unnecessary code

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Unified Diff: Objects/bytearrayobject.c

Issue 14203: bytearray_getbuffer: unnecessary code

Patch Set: Created 1 year, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

--- a/Objects/bytearrayobject.c

+++ b/Objects/bytearrayobject.c

@@ -56,10 +56,7 @@

{

int ret;

void *ptr;

- if (view == NULL) {

- obj->ob_exports++;

- return 0;

- }

ptr = (void *) PyByteArray_AS_STRING(obj);

ret = PyBuffer_FillInfo(view, (PyObject*)obj, ptr, Py_SIZE(obj), 0, flags);

if (ret >= 0) {

« no previous file with comments | « no previous file | no next file » | no next file with comments »