Issue 14057: Speedup sysconfig startup

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

#14057: Speedup sysconfig startup

Can't Edit
Can't Publish+Mail
Start Review

Created:
1 year, 2 months ago by victor.stinner

Modified:
1 year, 2 months ago

Reviewers:
greg

CC:
AntoinePitrou, haypo, eric.smith, tarek_ziade.org, eric.araujo, Arfrever.FTA_GMail.Com, Charles-François Natali, eric.snow

Visibility:
Public.

Patch Set 2 #

Total comments: 4

Created: 1 year, 2 months ago

Download raw patch set

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
		Lib/packaging/tests/test_command_install_data.py	View		1 chunk	+3 lines, -5 lines	0 comments	Download
		Lib/sysconfig.py	View	1	3 chunks	+111 lines, -3 lines	4 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

gregory.p.smith

http://bugs.python.org/review/14057/diff/4238/14810 File Lib/sysconfig.py (right): http://bugs.python.org/review/14057/diff/4238/14810#newcode120 Lib/sysconfig.py:120: optval = optval.lstrip() do we need to preserve trailing ...

1 year, 2 months ago #1

victor.stinner_haypocalc.com

1 year, 2 months ago #2

http://bugs.python.org/review/14057/diff/4238/14810
File Lib/sysconfig.py (right):

http://bugs.python.org/review/14057/diff/4238/14810#newcode120
Lib/sysconfig.py:120: optval = optval.lstrip()
On 2012/03/20 05:13:35, gregory.p.smith wrote:
> do we need to preserve trailing spaces on a value?  if not, optval.strip().

line.strip() is supposed to have already removed trailing spaces. Am I wrong?

http://bugs.python.org/review/14057/diff/4238/14810#newcode124
Lib/sysconfig.py:124: optname = optname.rstrip()
On 2012/03/20 05:13:35, gregory.p.smith wrote:
> you already did this above.

Ah yes, I forgot it in the cleanup.

Expand All Messages | Collapse All Messages

#14057: Speedup sysconfig startup

Patch Set 1 #

Patch Set 2 #

Messages