Issue 13959: Re-implement parts of imp in pure Python

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

#13959: Re-implement parts of imp in pure Python

Can't Edit
Can't Publish+Mail
Start Review

Created:
1 year, 2 months ago by brett

Modified:
11 months ago

Reviewers:
merwok

CC:
brett.cannon, Georg, jpe_wingware.com, AntoinePitrou, Benjamin Peterson, eric.araujo, Arfrever.FTA_GMail.Com, meadori, devnull_psf.upfronthosting.co.za, eric.snow, berkerpeksag

Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Total comments: 2

Patch Set 3 #

Patch Set 4 #

Patch Set 5 #

Patch Set 6 #

Patch Set 7 #

Patch Set 8 #

Created: 11 months ago

Download raw patch set

Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
Lib/imp.py	View	1 2 3 4 5 6 7	2 chunks	+6 lines, -1 line	0 comments	Download
Lib/importlib/_bootstrap.py	View	1 2 3 4 5 6 7	1 chunk	+1 line, -1 line	0 comments	Download
Python/import.c	View	1 2 3 4 5 6 7	5 chunks	+14 lines, -24 lines	0 comments	Download
Python/importlib.h	View	1 2 3 4 5 6 7	5 chunks	+169 lines, -167 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

eric.araujo

1 year, 2 months ago #1

Thanks a lot for tackling import!

http://bugs.python.org/review/13959/diff/4494/16010
File Lib/imp.py (right):

http://bugs.python.org/review/13959/diff/4494/16010#newcode12
Lib/imp.py:12: __all__ = (
Some tools break is __all__ is not a list.

http://bugs.python.org/review/13959/diff/4494/16012
File Lib/importlib/_bootstrap.py (right):

http://bugs.python.org/review/13959/diff/4494/16012#newcode1378
Lib/importlib/_bootstrap.py:1378: SOABI = "{}dm".format(TAG)
Is it correct that d and m are hard-coded?  IIUC they depend on configure
options.

Expand All Messages | Collapse All Messages