Issue 13897: Move fields relevant to coroutine/generators out of frame into generator/threadstate

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 13897: Move fields relevant to coroutine/generators out of frame into generator/threadstate

Can't Edit
Can't Publish+Mail
Start Review

Created:
3 months, 4 weeks ago by mark

Modified:
1 month, 2 weeks ago

Reviewers:
jimjjewett, benjamin

CC:
jcea, amaury.forgeotdarc, Nick Coghlan, AntoinePitrou, scoder, ron_adam, Benjamin Peterson, Mark.Shannon, Jim.Jewett

Visibility:
Public.

Patch Set 3 #

Created: 1 month, 2 weeks ago

Download raw patch set

Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
Include/frameobject.h	View		1 chunk	+0 lines, -9 lines	0 comments	Download
Include/genobject.h	View	1 2	1 chunk	+7 lines, -0 lines	0 comments	Download
Lib/test/test_sys.py	View	1 2	2 chunks	+2 lines, -2 lines	0 comments	Download
Objects/frameobject.c	View	1 2	5 chunks	+1 line, -12 lines	0 comments	Download
Objects/genobject.c	View	1 2	6 chunks	+102 lines, -6 lines	0 comments	Download
Python/ceval.c	View	1 2	4 chunks	+0 lines, -88 lines	0 comments	Download

Messages

Total messages: 2

Expand All Messages | Collapse All Messages

Jim.Jewett

http://bugs.python.org/review/13897/diff/4186/14521 File Python/sysmodule.c (right): http://bugs.python.org/review/13897/diff/4186/14521#newcode211 Python/sysmodule.c:211: while ((exc_info->exc_type == NULL || exc_info->exc_type == Py_None) && ...

2 months, 2 weeks ago #1

Benjamin Peterson

2 months, 2 weeks ago #2

Mostly requests for comments.

http://bugs.python.org/review/13897/diff/4186/14514
File Include/pystate.h (right):

http://bugs.python.org/review/13897/diff/4186/14514#newcode70
Include/pystate.h:70: /* In a generator, we need to be able to swap between the
exception
This comment isn't completely correct now that you're using the struct in the
thread state, also.

http://bugs.python.org/review/13897/diff/4186/14514#newcode109
Include/pystate.h:109: PyExcState exc_state;
It would be nice to have a comment explaining what difference between exc_state
and exc_info is.

http://bugs.python.org/review/13897/diff/4186/14520
File Python/pystate.c (right):

http://bugs.python.org/review/13897/diff/4186/14520#newcode300
Python/pystate.c:300: fprintf(stderr,
Should this perhaps be a fatal error?

Expand All Messages | Collapse All Messages