Objects/unicodeobject.c - Issue 13704: Random number generator in Python core

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Unified Diff: Objects/unicodeobject.c

Issue 13704: Random number generator in Python core

Patch Set: Created 1 year, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

--- a/Objects/unicodeobject.c Fri Dec 30 21:26:08 2011 +0100

+++ b/Objects/unicodeobject.c Tue Jan 03 21:48:43 2012 +0100

@@ -11107,7 +11107,7 @@

/* The hash function as a macro, gets expanded three times below. */

#define HASH(P) \

- x = (Py_uhash_t)*P << 7; \

+ x = Py_RndHashSeed + ((Py_uhash_t)*P << 7); \

gregory.p.smith 2012/01/15 02:18:38 Use ^ instead of +. Consistent with my suggestion

while (--len >= 0) \

x = (1000003*x) ^ (Py_uhash_t)*P++;