Random number generator in Python core

Include/pyrandom.h

+#ifndef Py_PYRANDOM_H
+#define Py_PYRANDOM_H
+
+int PyOS_URandom(unsigned char *buf, Py_ssize_t len);

[AntoinePitrou, 2012/01/04 18:54:01]

I don't think this function needs to be public. Better call it _PyOS_URandom.

+
+#define _Py_MT_N 624
+
+typedef struct {
+    unsigned long state[_Py_MT_N];
+    int index;
+} _Py_MT_RandomState;

[AntoinePitrou, 2012/01/04 18:54:01]

I think the naming is wrong. "MT" needn't appear in names. Also, "_Py_MT_N" is
cryptic: _Py_RandomStateSize instead?

+
+unsigned long _Py_MT_GenRand_Int32(_Py_MT_RandomState *state); // genrand_int32()

[AntoinePitrou, 2012/01/04 18:54:01]

_Py_RandInt33?

+double _Py_MT_GenRand_Res53(_Py_MT_RandomState *state); // random_random()

[AntoinePitrou, 2012/01/04 18:54:01]

_Py_RandDouble?
(etc., you get the point)

+void _Py_MT_GenRand_Init(_Py_MT_RandomState *state, unsigned long seed); // init_genrand()
+void _Py_MT_GenRand_InitArray(_Py_MT_RandomState *state, unsigned long init_key[], unsigned long key_length); // init_by_array
+
+#endif