Lib/inspect.py - Issue 13487: inspect.getmodule fails when module imports change sys.modules

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Unified Diff: Lib/inspect.py

Issue 13487: inspect.getmodule fails when module imports change sys.modules

Patch Set: Created 1 year, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

--- a/Lib/inspect.py Sun Nov 27 00:19:53 2011 +0100

+++ b/Lib/inspect.py Sat Nov 26 18:49:16 2011 -0800

@@ -482,7 +482,7 @@

return sys.modules.get(modulesbyfile[file])

# Update the filename to module name cache and check yet again

# Copy sys.modules in order to cope with changes while iterating

- for modname, module in sys.modules.items():

+ for modname, module in list(sys.modules.items()):

if ismodule(module) and hasattr(module, '__file__'):

f = module.__file__

if f == _filesbymodname.get(modname, None):

« no previous file with comments | « no previous file | no next file » | no next file with comments »