Rietveld Code Review Tool
Help | Bug tracker | Discussion group | Source code | Sign in
(621)

#13210: Support Visual Studio 2010

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 2 months ago by sable
Modified:
1 year ago
Reviewers:
kristjan
CC:
loewis, skippy.hammond_gmail.com, jackjansen_users.sourceforge.net, mark.dickinson, jaraco_jaraco.com, krisvale, sable, tim.golden, tarek_ziade.org, eric.araujo, brian.curtin, santa4nt, alexis, devnull_psf.upfronthosting.co.za, sbt, prlw1_cam.ac.uk
Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Patch Set 4 #

Total comments: 2

Patch Set 5 #

Patch Set 6 #

Patch Set 7 #

Patch Set 8 #

Unified diffs Side-by-side diffs Delta from patch set Stats Patch
PCbuild/_ctypes.vcxproj View 6 chunks +5 lines, -16 lines 0 comments Download
PCbuild/_ctypes_test.vcxproj View 7 2 chunks +0 lines, -7 lines 0 comments Download
PCbuild/_decimal.vcxproj View 7 3 chunks +7 lines, -14 lines 0 comments Download
PCbuild/_elementtree.vcxproj View 1 chunk +0 lines, -6 lines 0 comments Download
PCbuild/_hashlib.vcxproj View 1 chunk +0 lines, -5 lines 0 comments Download
PCbuild/_lzma.vcxproj View 1 chunk +0 lines, -6 lines 0 comments Download
PCbuild/_msi.vcxproj View 1 chunk +0 lines, -6 lines 0 comments Download
PCbuild/_multiprocessing.vcxproj View 1 chunk +0 lines, -6 lines 0 comments Download
PCbuild/_socket.vcxproj View 1 chunk +0 lines, -6 lines 0 comments Download
PCbuild/_sqlite3.vcxproj View 1 chunk +0 lines, -6 lines 0 comments Download
PCbuild/_ssl.vcxproj View 1 chunk +0 lines, -5 lines 0 comments Download
PCbuild/_testbuffer.vcxproj View 7 5 chunks +5 lines, -17 lines 0 comments Download
PCbuild/_testcapi.vcxproj View 1 chunk +0 lines, -6 lines 0 comments Download
PCbuild/_tkinter.vcxproj View 1 chunk +0 lines, -5 lines 0 comments Download
PCbuild/debug.props View 7 2 chunks +3 lines, -6 lines 0 comments Download
PCbuild/env.bat View 1 chunk +6 lines, -2 lines 0 comments Download
PCbuild/kill_python.vcxproj View 1 chunk +0 lines, -6 lines 0 comments Download
PCbuild/make_buildinfo.vcxproj View 2 chunks +0 lines, -2 lines 0 comments Download
PCbuild/make_versioninfo.vcxproj View 4 chunks +6 lines, -4 lines 0 comments Download
PCbuild/pcbuild.sln View 1 chunk +3 lines, -2 lines 0 comments Download
PCbuild/pyd.props View 2 chunks +1 line, -3 lines 0 comments Download
PCbuild/pyd_d.props View 7 2 chunks +4 lines, -14 lines 0 comments Download
PCbuild/pyexpat.vcxproj View 1 chunk +0 lines, -6 lines 0 comments Download
PCbuild/pyproject.props View 7 4 chunks +12 lines, -5 lines 0 comments Download
PCbuild/python.vcxproj View 1 chunk +0 lines, -8 lines 0 comments Download
PCbuild/pythoncore.vcxproj View 12 chunks +8 lines, -26 lines 0 comments Download
PCbuild/pythonw.vcxproj View 1 chunk +0 lines, -8 lines 0 comments Download
PCbuild/readme.txt View 2 chunks +6 lines, -12 lines 0 comments Download
PCbuild/release.props View 2 chunks +2 lines, -8 lines 0 comments Download
PCbuild/select.vcxproj View 1 chunk +0 lines, -6 lines 0 comments Download
PCbuild/sqlite3.vcxproj View 1 chunk +0 lines, -3 lines 0 comments Download
PCbuild/unicodedata.vcxproj View 1 chunk +0 lines, -6 lines 0 comments Download
PCbuild/w9xpopen.vcxproj View 1 chunk +24 lines, -0 lines 0 comments Download
PCbuild/winsound.vcxproj View 1 chunk +0 lines, -6 lines 0 comments Download
PCbuild/x64.props View 1 chunk +1 line, -1 line 0 comments Download
PCbuild/xxlimited.vcxproj View 7 6 chunks +7 lines, -11 lines 0 comments Download

Messages

Total messages: 1
krisvale
1 year ago #1
http://bugs.python.org/review/13210/diff/4802/16999
File PC/msvcrtmodule.c (right):

http://bugs.python.org/review/13210/diff/4802/16999#newcode499
PC/msvcrtmodule.c:499: /* TODO-BC: the following 3 are from VS2008, may want to
remove? */
Probably not remove, if we want to maintain support for 2008, e.g. in PC/VC9
dierectory.

VS2010 no longer has SxS stuff, so they are probably gone.
Btw, hyou will want to define "st" locally, otherwise you get unused variable
warning

http://bugs.python.org/review/13210/diff/4802/16999#newcode524
PC/msvcrtmodule.c:524: st = PyModule_AddObject(m, "CRT_ASSEMBLY_VERSION",
version);
Not sure about the "ASSEMBLY" here, again, 2010 does not use manifests for the
crt (SxS, assemblies, etc)
Sign in to reply to this message.

RSS Feeds Recent Issues | This issue
This is Rietveld cbc36f91f3f7