Allow to explicitly set the method of urllib.request.Request

[eric.araujo]

http://bugs.python.org/review/12614/diff/3068/8107
File Doc/library/urllib.request.rst (right):

http://bugs.python.org/review/12614/diff/3068/8107#newcode179
Doc/library/urllib.request.rst:179: *method* The method to use (e.g. GET, POST
...)
I would use this markup, to make clear the values are strings, and not for
example module constants:

``'GET'``, ``'POST'``

[ezio.melotti]

http://bugs.python.org/review/12614/diff/3068/8107
File Doc/library/urllib.request.rst (right):

http://bugs.python.org/review/12614/diff/3068/8107#newcode136
Doc/library/urllib.request.rst:136: method=None)
Does this work on a newline?

http://bugs.python.org/review/12614/diff/3068/8107#newcode179
Doc/library/urllib.request.rst:179: *method* The method to use (e.g. GET, POST
...)
On 2011/07/22 23:14:44, eric.araujo wrote:
> ``'GET'``, ``'POST'``
 +1

[eric.araujo]

http://bugs.python.org/review/12614/diff/3068/8107
File Doc/library/urllib.request.rst (right):

http://bugs.python.org/review/12614/diff/3068/8107#newcode136
Doc/library/urllib.request.rst:136: method=None)
On 2011/07/22 23:17:54, ezio.melotti wrote:
> Does this work on a newline?

Yep, you’ll probably need to escape the end of line:

    .. class:: Spam(blah, blah2, \
                    blah3)

[tebeka]

On 2011/07/22 23:14:44, eric.araujo wrote:
> http://bugs.python.org/review/12614/diff/3068/8107
> File Doc/library/urllib.request.rst (right):
> 
> http://bugs.python.org/review/12614/diff/3068/8107#newcode179
> Doc/library/urllib.request.rst:179: *method* The method to use (e.g. GET, POST
> ...)
> I would use this markup, to make clear the values are strings, and not for
> example module constants:
> 
> ``'GET'``, ``'POST'``

OK

[tebeka]

On 2011/07/22 23:52:58, eric.araujo wrote:
> http://bugs.python.org/review/12614/diff/3068/8107
> File Doc/library/urllib.request.rst (right):
> 
> http://bugs.python.org/review/12614/diff/3068/8107#newcode136
> Doc/library/urllib.request.rst:136: method=None)
> On 2011/07/22 23:17:54, ezio.melotti wrote:
> > Does this work on a newline?
> 
> Yep, you’ll probably need to escape the end of line:
> 
>     .. class:: Spam(blah, blah2, \
>                     blah3)

OK

[eric.araujo]

http://bugs.python.org/review/12614/diff/3083/8147
File Lib/urllib/request.py (right):

http://bugs.python.org/review/12614/diff/3083/8147#newcode206
Lib/urllib/request.py:206: if self._method:
Should test if self._method is not None