Issue 12576: urlib.request fails to open some sites

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Issue 12576: urlib.request fails to open some sites

Can't Edit
Can't Publish+Mail
Start Review

Created:
10 months ago by daniel.ugra

Modified:
10 months ago

Reviewers:
merwok

CC:
barry, Georg, terry.reedy, orsenthil, haypo, nneonneo, nadeem.vawda, ezio.melotti, eric.araujo, daniel.ugra, santa4nt, sorcio_gmail.com, devnull_psf.upfronthosting.co.za, angus_amcinnes.info, orsenthil, santa4nt, devnull_psf.upfronthosting.co.za

Visibility:
Public.

Patch Set 1 #

Total comments: 1

Created: 10 months ago

Download raw patch set

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
		Lib/urllib/request.py	View		1 chunk	+5 lines, -3 lines	1 comment	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

eric.araujo

10 months ago #1

LGTM

http://bugs.python.org/review/12576/diff/3079/8139
File Lib/urllib/request.py (right):

http://bugs.python.org/review/12576/diff/3079/8139#newcode1150
Lib/urllib/request.py:1150: r = h.getresponse() # an HTTPResponse instance
I notice that you changed the spacing before the # character; PEP 8 recommends
two spaces, to make the comment more distinct from the code.

Expand All Messages | Collapse All Messages