Lib/test/test_subprocess.py - Issue 12044: subprocess.Popen.__exit__ doesn't wait for process end

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Unified Diff: Lib/test/test_subprocess.py

Issue 12044: subprocess.Popen.__exit__ doesn't wait for process end

Patch Set: Created 2 years ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

--- a/Lib/test/test_subprocess.py Wed May 11 22:37:50 2011 +0800

+++ b/Lib/test/test_subprocess.py Wed May 11 18:35:39 2011 +0200

@@ -1590,7 +1590,8 @@

def test_returncode(self):

with subprocess.Popen([sys.executable, "-c",

"import sys; sys.exit(100)"]) as proc:

- proc.wait()

+ pass

+ # __exit__ calls wait(), so the returncode should be set

self.assertEqual(proc.returncode, 100)

def test_communicate_stdin(self):

« no previous file with comments | « Lib/subprocess.py ('k') | no next file » | no next file with comments »