Issue 12040: Expose a Process.sentinel property (and fix polling loop in Process.join())

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

#12040: Expose a Process.sentinel property (and fix polling loop in Process.join())

Can't Edit
Can't Publish+Mail
Start Review

Created:
2 years ago by pitrou

Modified:
2 years ago

Reviewers:
greg

CC:
gregory.p.smith, AntoinePitrou, haypo, jnoller_gmail.com, brian.curtin, asksol, Charles-François Natali, devnull_devnull, asksol, brian.curtin, devnull_psf.upfronthosting.co.za

Visibility:
Public.

Patch Set 1 #

Total comments: 2

Patch Set 2 #

Created: 2 years ago

Download raw patch set

Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
Doc/library/multiprocessing.rst	View		1 chunk	+14 lines, -0 lines	0 comments	Download
Lib/multiprocessing/forking.py	View	1	5 chunks	+20 lines, -14 lines	0 comments	Download
Lib/multiprocessing/process.py	View		2 chunks	+12 lines, -0 lines	0 comments	Download
Lib/multiprocessing/util.py	View		2 chunks	+21 lines, -0 lines	0 comments	Download
Lib/test/test_multiprocessing.py	View	1	2 chunks	+37 lines, -0 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

gregory.p.smith

2 years ago #1

http://bugs.python.org/review/12040/diff/2577/6224
File Lib/multiprocessing/forking.py (right):

http://bugs.python.org/review/12040/diff/2577/6224#newcode160
Lib/multiprocessing/forking.py:160: r = select.select([self.sentinel], [], [],
timeout)[0]
I believe you need to handle EINTR on this call and retry the select.

http://bugs.python.org/review/12040/diff/2577/6226
File Lib/test/test_multiprocessing.py (right):

http://bugs.python.org/review/12040/diff/2577/6226#newcode89
Lib/test/test_multiprocessing.py:89: return handle in select([handle], [], [],
timeout)[0]
handle EINTR and retry?

Expand All Messages | Collapse All Messages