Lib/zipfile.py - Issue 11981: dupe self.fp.tell() in zipfile.ZipFile.writestr

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

Unified Diff: Lib/zipfile.py

Issue 11981: dupe self.fp.tell() in zipfile.ZipFile.writestr

Patch Set: Created 2 years ago

Use n/p to move between diff chunks; N/P to move between comments. Please Sign in to add in-line comments.

Jump to:

--- a/Lib/zipfile.py Mon May 02 12:31:17 2011 -0400

+++ b/Lib/zipfile.py Mon May 02 18:50:32 2011 +0200

@@ -1179,7 +1179,6 @@

zinfo.compress_size = len(data) # Compressed size

else:

zinfo.compress_size = zinfo.file_size

- zinfo.header_offset = self.fp.tell() # Start of header data

self.fp.write(zinfo.FileHeader())

self.fp.write(data)

self.fp.flush()

« no previous file with comments | « no previous file | no next file » | no next file with comments »