Issue 10812: Add some posix functions

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s :	save comment
<Esc> :	cancel edit

#10812: Add some posix functions

Can't Edit
Can't Publish+Mail
Start Review

Created:
2 years, 2 months ago by rosslagerwall

Modified:
2 years, 2 months ago

Reviewers:
greg

CC:
loewis, Georg, gregory.p.smith, ronaldoussoren, sasha, AntoinePitrou, giampaolo.rodola, ned.deily, Arfrever.FTA_GMail.Com, rosslagerwall, devnull_psf.upfronthosting.co.za

Visibility:
Public.

Patch Set 1 #

Patch Set 2 #

Patch Set 3 #

Patch Set 4 #

Patch Set 5 #

Total comments: 3

Created: 2 years, 2 months ago

Download raw patch set

Unified diffs	Side-by-side diffs	Delta from patch set	Stats			Patch
Doc/library/os.rst	View	1 2 3 4	11 chunks	+257 lines, -0 lines	0 comments	Download
Lib/test/test_posix.py	View	1 2 3 4	2 chunks	+170 lines, -1 line	0 comments	Download
Modules/posixmodule.c	View	1 2 3 4	29 chunks	+876 lines, -120 lines	3 comments	Download
configure.in	View	1 2 3 4	2 chunks	+11 lines, -10 lines	0 comments	Download

Messages

Total messages: 1

Expand All Messages | Collapse All Messages

gregory.p.smith

2 years, 2 months ago #1

http://bugs.python.org/review/10812/diff/1871/3539
File Modules/posixmodule.c (right):

http://bugs.python.org/review/10812/diff/1871/3539#newcode355
Modules/posixmodule.c:355: PyParse_off_t(PyObject* arg, void* addr)
Why can't this be off_t *addr ?

Also the function should be declared static and not use the upper case PyParse
name as it is for internal use in this file.

I can imagine this could be useful elsewhere; but we should change it from
static to something that lives in a library as cpython API later when we find
another use for it.

http://bugs.python.org/review/10812/diff/1871/3539#newcode3455
Modules/posixmodule.c:3455: Like utime(), but if path is a symbolic link, it is
not dereferenced.");
Like utimes() I think you mean?

http://bugs.python.org/review/10812/diff/1871/3539#newcode4452
Modules/posixmodule.c:4452: Gets the host id, a unique 32-bit identifier for the
current machine.");
don't claim that it is unique. :)   gethostid and sethostid are old deprecated C
library APIs, I hope nobody uses them.  Do you have code that needs them?

Expand All Messages | Collapse All Messages