Message98472
This is slightly incorrect: if PyFile_FromFile fails for another reason (PyString_FromString(name) runs out of memory), the fp is not closed and the caller is right to call fclose().
IMO PyFile_FromFile() should be changed to consistently leave the fp opened when NULL is returned. But then, many usages of this function are incorrect, e.g in posixmodule.c :-( |
|
Date |
User |
Action |
Args |
2010-01-28 18:28:31 | amaury.forgeotdarc | set | recipients:
+ amaury.forgeotdarc, brett.cannon, r.david.murray, Trundle, flox |
2010-01-28 18:28:29 | amaury.forgeotdarc | set | messageid: <1264703309.15.0.392495786558.issue7732@psf.upfronthosting.co.za> |
2010-01-28 18:28:13 | amaury.forgeotdarc | link | issue7732 messages |
2010-01-28 18:28:12 | amaury.forgeotdarc | create | |
|